增加golangci-lint配置

.golangci.yaml

@@ -0,0 +1,74 @@
+# https://golangci-lint.run/usage/configuration/
+
+linters:
+  enable-all: true
+  disable:
+    - ifshort
+    - exhaustivestruct
+    - golint
+    - nosnakecase
+    - scopelint
+    - varcheck
+    - structcheck
+    - interfacer
+    - exhaustivestruct
+    - maligned
+    - deadcode
+    - dogsled
+    - wrapcheck
+    - wastedassign
+    - varnamelen
+    - testpackage
+    - thelper
+    - nilerr
+    - sqlclosecheck
+    - paralleltest
+    - nonamedreturns
+    - nlreturn
+    - nakedret
+    - ireturn
+    - interfacebloat
+    - gosmopolitan
+    - gomnd
+    - goerr113
+    - gochecknoglobals
+    - exhaustruct
+    - errorlint
+    - depguard
+    - exhaustive
+    - containedctx
+    - wsl
+    - cyclop
+    - dupword
+    - errchkjson
+    - contextcheck
+    - tagalign
+    - dupl
+    - forbidigo
+    - funlen
+    - goconst
+    - godox
+    - gosec
+    - lll
+    - nestif
+    - revive
+    - unparam
+    - stylecheck
+    - gocritic
+    - gofumpt
+    - gomoddirectives
+    - godot
+    - gofmt
+    - gocognit
+    - mirror
+    - gocyclo
+    - gochecknoinits
+    - gci
+    - maintidx
+    - prealloc
+    - goimports
+    - errname
+    - musttag
+    - forcetypeassert
+    - whitespace
+    - noctx

internal/caches/storage_file_test.go

@@ -159,7 +159,7 @@ func TestFileStorage_OpenWriter_HTTP(t *testing.T) {
 	t.Log(writer)
 
 	resp := &http.Response{
-		StatusCode: 200,
+		StatusCode: http.StatusOK,
 		Header: http.Header{
 			"Content-Type":  []string{"text/html; charset=utf-8"},
 			"Last-Modified": []string{"Wed, 06 Jan 2021 10:03:29 GMT"},

internal/encrypt/method_aes_128_cfb_test.go

@@ -53,7 +53,6 @@ func TestAES128CFBMethod_Encrypt2(t *testing.T) {
 	}
 
 	{
-
 		a := []byte{1}
 		_, err = method.Decrypt(a)
 		if err != nil {

internal/events/utils_test.go

@@ -9,8 +9,8 @@ func TestOn(t *testing.T) {
 	type User struct {
 		name string
 	}
-	var u = &User{}
+	var u = &User{name: "lily"}
-	var u2 = &User{}
+	var u2 = &User{name: "lucy"}
 
 	events.On("hello", func() {
 		t.Log("world")

internal/nodes/http_request_reverse_proxy.go

@@ -258,6 +258,7 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 	}
 
 	var resp *http.Response
+	var respBodyIsClosed bool
 	var requestErr error
 	var requestErrCode string
 	if isHTTPOrigin { // 普通HTTP(S)源站
@@ -296,6 +297,15 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 		this.writeCode(http.StatusBadGateway, "The type of origin site has not been supported", "设置的源站类型尚未支持")
 		return
 	}
+
+	if resp != nil && resp.Body != nil {
+		defer func() {
+			if !respBodyIsClosed {
+				_ = resp.Body.Close()
+			}
+		}()
+	}
+
 	if requestErr != nil {
 		// 客户端取消请求，则不提示
 		httpErr, ok := requestErr.(*url.Error)
@@ -324,10 +334,6 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 				shouldRetry = true
 				this.uri = oldURI // 恢复备份
 
-				if resp != nil && resp.Body != nil {
-					_ = resp.Body.Close()
-				}
-
 				if httpErr.Err != io.EOF {
 					remotelogs.WarnServer("HTTP_REQUEST_REVERSE_PROXY", this.URL()+": Request origin server failed: "+requestErr.Error())
 				}
@@ -366,9 +372,6 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 				this.write50x(requestErr, http.StatusBadGateway, "Failed to read origin site", "源站读取失败", true)
 			}
 		}
-		if resp != nil && resp.Body != nil {
-			_ = resp.Body.Close()
-		}
 		return
 	}
 
@@ -376,9 +379,6 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 	if isLowVersionHTTP && resp.ContentLength < 0 {
 		this.writer.WriteHeader(http.StatusBadRequest)
 		_, _ = this.writer.WriteString("The content does not support " + this.RawReq.Proto + " request.")
-		if resp.Body != nil {
-			_ = resp.Body.Close()
-		}
 		return
 	}
 
@@ -395,20 +395,12 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 	// WAF对出站进行检查
 	if this.web.FirewallRef != nil && this.web.FirewallRef.IsOn {
 		if this.doWAFResponse(resp) {
-			err := resp.Body.Close()
-			if err != nil {
-				remotelogs.WarnServer("HTTP_REQUEST_REVERSE_PROXY", this.URL()+": Closing Error (WAF): "+err.Error())
-			}
 			return
 		}
 	}
 
 	// 特殊页面
 	if this.doPage(resp.StatusCode) {
-		err := resp.Body.Close()
-		if err != nil {
-			remotelogs.WarnServer("HTTP_REQUEST_REVERSE_PROXY", this.URL()+": Closing error (Page): "+err.Error())
-		}
 		return
 	}
 
@@ -499,6 +491,7 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 		_, _ = io.CopyBuffer(this.writer, resp.Body, buf)
 		utils.BytePool4k.Put(buf)
 		_ = resp.Body.Close()
+		respBodyIsClosed = true
 
 		this.writer.SetOk()
 		return
@@ -550,6 +543,7 @@ func (this *HTTPRequest) doOriginRequest(failedOriginIds []int64, failedLnNodeId
 	pool.Put(buf)
 
 	var closeErr = resp.Body.Close()
+	respBodyIsClosed = true
 	if closeErr != nil {
 		if !this.canIgnore(closeErr) {
 			remotelogs.WarnServer("HTTP_REQUEST_REVERSE_PROXY", this.URL()+": Closing error: "+closeErr.Error())

internal/nodes/http_writer.go

@@ -24,7 +24,6 @@ import (
 	_ "golang.org/x/image/webp"
 	"image"
 	"image/gif"
-	_ "image/gif"
 	_ "image/jpeg"
 	_ "image/png"
 	"io"

internal/remotelogs/utils.go

@@ -60,7 +60,6 @@ func Println(tag string, description string) {
 		CreatedAt:   time.Now().Unix(),
 	}:
 	default:
-
 	}
 }
 
@@ -78,7 +77,6 @@ func Warn(tag string, description string) {
 		CreatedAt:   time.Now().Unix(),
 	}:
 	default:
-
 	}
 }
 

internal/utils/writers/writer_rate_limit.go

@@ -79,7 +79,6 @@ func (this *RateLimitWriter) write(p []byte) (n int, err error) {
 			err = io.EOF
 			return
 		default:
-
 		}
 
 		this.written += n

internal/waf/checkpoints/response_general_header_length.go

@@ -19,7 +19,6 @@ func (this *ResponseGeneralHeaderLengthCheckpoint) IsComposed() bool {
 }
 
 func (this *ResponseGeneralHeaderLengthCheckpoint) RequestValue(req requests.Request, param string, options maps.Map, ruleId int64) (value interface{}, hasRequestBody bool, sysErr error, userErr error) {
-
 	return
 }