Do not send "registration success email" for external auth sources (#24632)

Co-author: @pboguslawski 


"registration success email" is only used for notifying a user that "you
have a new account now" when the account is created by admin manually.

When a user uses external auth source, they already knows that they has
the account, so do not send such email.

Co-authored-by: Giteabot <teabot@gitea.io>

services/auth/source/smtp/source_authenticate.go

@@ -12,7 +12,6 @@ import (
 	auth_model "code.gitea.io/gitea/models/auth"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/util"
-	"code.gitea.io/gitea/services/mailer"
 )
 
 // Authenticate queries if the provided login/password is authenticates against the SMTP server
@@ -82,8 +81,6 @@ func (source *Source) Authenticate(user *user_model.User, userName, password str
 		return user, err
 	}
 
-	mailer.SendRegisterNotifyMail(user)
-
 	return user, nil
 }