mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)
Found using
`find . -type f -name '*.go' -print -exec vim {} -c
':%s/fmt\.Errorf(\(.*\)%v\(.*\)err/fmt.Errorf(\1%w\2err/g' -c ':wq' \;`
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
			
			
This commit is contained in:
		@@ -228,7 +228,7 @@ func (pr *PullRequest) loadAttributes(ctx context.Context) (err error) {
 | 
			
		||||
			pr.MergerID = -1
 | 
			
		||||
			pr.Merger = user_model.NewGhostUser()
 | 
			
		||||
		} else if err != nil {
 | 
			
		||||
			return fmt.Errorf("getUserByID [%d]: %v", pr.MergerID, err)
 | 
			
		||||
			return fmt.Errorf("getUserByID [%d]: %w", pr.MergerID, err)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
@@ -255,7 +255,7 @@ func (pr *PullRequest) LoadHeadRepoCtx(ctx context.Context) (err error) {
 | 
			
		||||
 | 
			
		||||
		pr.HeadRepo, err = repo_model.GetRepositoryByIDCtx(ctx, pr.HeadRepoID)
 | 
			
		||||
		if err != nil && !repo_model.IsErrRepoNotExist(err) { // Head repo maybe deleted, but it should still work
 | 
			
		||||
			return fmt.Errorf("getRepositoryByID(head): %v", err)
 | 
			
		||||
			return fmt.Errorf("getRepositoryByID(head): %w", err)
 | 
			
		||||
		}
 | 
			
		||||
		pr.isHeadRepoLoaded = true
 | 
			
		||||
	}
 | 
			
		||||
@@ -290,7 +290,7 @@ func (pr *PullRequest) LoadBaseRepoCtx(ctx context.Context) (err error) {
 | 
			
		||||
 | 
			
		||||
	pr.BaseRepo, err = repo_model.GetRepositoryByIDCtx(ctx, pr.BaseRepoID)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return fmt.Errorf("repo_model.GetRepositoryByID(base): %v", err)
 | 
			
		||||
		return fmt.Errorf("repo_model.GetRepositoryByID(base): %w", err)
 | 
			
		||||
	}
 | 
			
		||||
	return nil
 | 
			
		||||
}
 | 
			
		||||
@@ -482,7 +482,7 @@ func (pr *PullRequest) SetMerged(ctx context.Context) (bool, error) {
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if _, err := changeIssueStatus(ctx, pr.Issue, pr.Merger, true, true); err != nil {
 | 
			
		||||
		return false, fmt.Errorf("Issue.changeStatus: %v", err)
 | 
			
		||||
		return false, fmt.Errorf("Issue.changeStatus: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// reset the conflicted files as there cannot be any if we're merged
 | 
			
		||||
@@ -490,7 +490,7 @@ func (pr *PullRequest) SetMerged(ctx context.Context) (bool, error) {
 | 
			
		||||
 | 
			
		||||
	// We need to save all of the data used to compute this merge as it may have already been changed by TestPatch. FIXME: need to set some state to prevent TestPatch from running whilst we are merging.
 | 
			
		||||
	if _, err := sess.Where("id = ?", pr.ID).Cols("has_merged, status, merge_base, merged_commit_id, merger_id, merged_unix, conflicted_files").Update(pr); err != nil {
 | 
			
		||||
		return false, fmt.Errorf("Failed to update pr[%d]: %v", pr.ID, err)
 | 
			
		||||
		return false, fmt.Errorf("Failed to update pr[%d]: %w", pr.ID, err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	return true, nil
 | 
			
		||||
@@ -507,7 +507,7 @@ func NewPullRequest(outerCtx context.Context, repo *repo_model.Repository, issue
 | 
			
		||||
 | 
			
		||||
	idx, err := db.GetNextResourceIndex(ctx, "issue_index", repo.ID)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return fmt.Errorf("generate pull request index failed: %v", err)
 | 
			
		||||
		return fmt.Errorf("generate pull request index failed: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	issue.Index = idx
 | 
			
		||||
@@ -522,18 +522,18 @@ func NewPullRequest(outerCtx context.Context, repo *repo_model.Repository, issue
 | 
			
		||||
		if repo_model.IsErrUserDoesNotHaveAccessToRepo(err) || IsErrNewIssueInsert(err) {
 | 
			
		||||
			return err
 | 
			
		||||
		}
 | 
			
		||||
		return fmt.Errorf("newIssue: %v", err)
 | 
			
		||||
		return fmt.Errorf("newIssue: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	pr.Index = issue.Index
 | 
			
		||||
	pr.BaseRepo = repo
 | 
			
		||||
	pr.IssueID = issue.ID
 | 
			
		||||
	if err = db.Insert(ctx, pr); err != nil {
 | 
			
		||||
		return fmt.Errorf("insert pull repo: %v", err)
 | 
			
		||||
		return fmt.Errorf("insert pull repo: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if err = committer.Commit(); err != nil {
 | 
			
		||||
		return fmt.Errorf("Commit: %v", err)
 | 
			
		||||
		return fmt.Errorf("Commit: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	return nil
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user