mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)
Found using
`find . -type f -name '*.go' -print -exec vim {} -c
':%s/fmt\.Errorf(\(.*\)%v\(.*\)err/fmt.Errorf(\1%w\2err/g' -c ':wq' \;`
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
			
			
This commit is contained in:
		@@ -31,23 +31,23 @@ func AddRepository(ctx context.Context, t *organization.Team, repo *repo_model.R
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if err = organization.IncrTeamRepoNum(ctx, t.ID); err != nil {
 | 
			
		||||
		return fmt.Errorf("update team: %v", err)
 | 
			
		||||
		return fmt.Errorf("update team: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	t.NumRepos++
 | 
			
		||||
 | 
			
		||||
	if err = access_model.RecalculateTeamAccesses(ctx, repo, 0); err != nil {
 | 
			
		||||
		return fmt.Errorf("recalculateAccesses: %v", err)
 | 
			
		||||
		return fmt.Errorf("recalculateAccesses: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// Make all team members watch this repo if enabled in global settings
 | 
			
		||||
	if setting.Service.AutoWatchNewRepos {
 | 
			
		||||
		if err = t.GetMembersCtx(ctx); err != nil {
 | 
			
		||||
			return fmt.Errorf("getMembers: %v", err)
 | 
			
		||||
			return fmt.Errorf("getMembers: %w", err)
 | 
			
		||||
		}
 | 
			
		||||
		for _, u := range t.Members {
 | 
			
		||||
			if err = repo_model.WatchRepo(ctx, u.ID, repo.ID, true); err != nil {
 | 
			
		||||
				return fmt.Errorf("watchRepo: %v", err)
 | 
			
		||||
				return fmt.Errorf("watchRepo: %w", err)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
@@ -60,13 +60,13 @@ func AddRepository(ctx context.Context, t *organization.Team, repo *repo_model.R
 | 
			
		||||
func addAllRepositories(ctx context.Context, t *organization.Team) error {
 | 
			
		||||
	orgRepos, err := organization.GetOrgRepositories(ctx, t.OrgID)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return fmt.Errorf("get org repos: %v", err)
 | 
			
		||||
		return fmt.Errorf("get org repos: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for _, repo := range orgRepos {
 | 
			
		||||
		if !organization.HasTeamRepo(ctx, t.OrgID, t.ID, repo.ID) {
 | 
			
		||||
			if err := AddRepository(ctx, t, repo); err != nil {
 | 
			
		||||
				return fmt.Errorf("AddRepository: %v", err)
 | 
			
		||||
				return fmt.Errorf("AddRepository: %w", err)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
@@ -180,7 +180,7 @@ func removeRepository(ctx context.Context, t *organization.Team, repo *repo_mode
 | 
			
		||||
 | 
			
		||||
	teamUsers, err := organization.GetTeamUsersByTeamID(ctx, t.ID)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return fmt.Errorf("getTeamUsersByTeamID: %v", err)
 | 
			
		||||
		return fmt.Errorf("getTeamUsersByTeamID: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
	for _, teamUser := range teamUsers {
 | 
			
		||||
		has, err := access_model.HasAccess(ctx, teamUser.UID, repo)
 | 
			
		||||
@@ -287,7 +287,7 @@ func NewTeam(t *organization.Team) (err error) {
 | 
			
		||||
	if t.IncludesAllRepositories {
 | 
			
		||||
		err = addAllRepositories(ctx, t)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return fmt.Errorf("addAllRepositories: %v", err)
 | 
			
		||||
			return fmt.Errorf("addAllRepositories: %w", err)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
@@ -329,7 +329,7 @@ func UpdateTeam(t *organization.Team, authChanged, includeAllChanged bool) (err
 | 
			
		||||
 | 
			
		||||
	if _, err = sess.ID(t.ID).Cols("name", "lower_name", "description",
 | 
			
		||||
		"can_create_org_repo", "authorize", "includes_all_repositories").Update(t); err != nil {
 | 
			
		||||
		return fmt.Errorf("update: %v", err)
 | 
			
		||||
		return fmt.Errorf("update: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// update units for team
 | 
			
		||||
@@ -351,12 +351,12 @@ func UpdateTeam(t *organization.Team, authChanged, includeAllChanged bool) (err
 | 
			
		||||
	// Update access for team members if needed.
 | 
			
		||||
	if authChanged {
 | 
			
		||||
		if err = t.GetRepositoriesCtx(ctx); err != nil {
 | 
			
		||||
			return fmt.Errorf("getRepositories: %v", err)
 | 
			
		||||
			return fmt.Errorf("getRepositories: %w", err)
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		for _, repo := range t.Repos {
 | 
			
		||||
			if err = access_model.RecalculateTeamAccesses(ctx, repo, 0); err != nil {
 | 
			
		||||
				return fmt.Errorf("recalculateTeamAccesses: %v", err)
 | 
			
		||||
				return fmt.Errorf("recalculateTeamAccesses: %w", err)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
@@ -365,7 +365,7 @@ func UpdateTeam(t *organization.Team, authChanged, includeAllChanged bool) (err
 | 
			
		||||
	if includeAllChanged && t.IncludesAllRepositories {
 | 
			
		||||
		err = addAllRepositories(ctx, t)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return fmt.Errorf("addAllRepositories: %v", err)
 | 
			
		||||
			return fmt.Errorf("addAllRepositories: %w", err)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
@@ -397,7 +397,7 @@ func DeleteTeam(t *organization.Team) error {
 | 
			
		||||
			builder.Select("id").From("repository").Where(builder.Eq{"owner_id": t.OrgID})).
 | 
			
		||||
			Find(&protections)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return fmt.Errorf("findProtectedBranches: %v", err)
 | 
			
		||||
			return fmt.Errorf("findProtectedBranches: %w", err)
 | 
			
		||||
		}
 | 
			
		||||
		for _, p := range protections {
 | 
			
		||||
			var matched1, matched2, matched3 bool
 | 
			
		||||
@@ -419,7 +419,7 @@ func DeleteTeam(t *organization.Team) error {
 | 
			
		||||
					"merge_whitelist_team_i_ds",
 | 
			
		||||
					"approvals_whitelist_team_i_ds",
 | 
			
		||||
				).Update(p); err != nil {
 | 
			
		||||
					return fmt.Errorf("updateProtectedBranches: %v", err)
 | 
			
		||||
					return fmt.Errorf("updateProtectedBranches: %w", err)
 | 
			
		||||
				}
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
@@ -496,14 +496,14 @@ func AddTeamMember(team *organization.Team, userID int64) error {
 | 
			
		||||
		And("mode < ?", team.AccessMode).
 | 
			
		||||
		SetExpr("mode", team.AccessMode).
 | 
			
		||||
		Update(new(access_model.Access)); err != nil {
 | 
			
		||||
		return fmt.Errorf("update user accesses: %v", err)
 | 
			
		||||
		return fmt.Errorf("update user accesses: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// for not exist access
 | 
			
		||||
	var repoIDs []int64
 | 
			
		||||
	accessSubQuery := builder.Select("repo_id").From("access").Where(builder.Eq{"user_id": userID})
 | 
			
		||||
	if err := sess.SQL(subQuery.And(builder.NotIn("repo_id", accessSubQuery))).Find(&repoIDs); err != nil {
 | 
			
		||||
		return fmt.Errorf("select id accesses: %v", err)
 | 
			
		||||
		return fmt.Errorf("select id accesses: %w", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	accesses := make([]*access_model.Access, 0, 100)
 | 
			
		||||
@@ -511,7 +511,7 @@ func AddTeamMember(team *organization.Team, userID int64) error {
 | 
			
		||||
		accesses = append(accesses, &access_model.Access{RepoID: repoID, UserID: userID, Mode: team.AccessMode})
 | 
			
		||||
		if (i%100 == 0 || i == len(repoIDs)-1) && len(accesses) > 0 {
 | 
			
		||||
			if err = db.Insert(ctx, accesses); err != nil {
 | 
			
		||||
				return fmt.Errorf("insert new user accesses: %v", err)
 | 
			
		||||
				return fmt.Errorf("insert new user accesses: %w", err)
 | 
			
		||||
			}
 | 
			
		||||
			accesses = accesses[:0]
 | 
			
		||||
		}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user