mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	API add/generalize pagination (#9452)
* paginate results * fixed deadlock * prevented breaking change * updated swagger * go fmt * fixed find topic * go mod tidy * go mod vendor with go1.13.5 * fixed repo find topics * fixed unit test * added Limit method to Engine struct; use engine variable when provided; fixed gitignore * use ItemsPerPage for default pagesize; fix GetWatchers, getOrgUsersByOrgID and GetStargazers; fix GetAllCommits headers; reverted some changed behaviors * set Page value on Home route * improved memory allocations * fixed response headers * removed logfiles * fixed import order * import order * improved swagger * added function to get models.ListOptions from context * removed pagesize diff on unit test * fixed imports * removed unnecessary struct field * fixed go fmt * scoped PR * code improvements * code improvements * go mod tidy * fixed import order * fixed commit statuses session * fixed files headers * fixed headers; added pagination for notifications * go mod tidy * go fmt * removed Private from user search options; added setting.UI.IssuePagingNum as default valeu on repo's issues list * Apply suggestions from code review Co-Authored-By: 6543 <6543@obermui.de> Co-Authored-By: zeripath <art27@cantab.net> * fixed build error * CI.restart() * fixed merge conflicts resolve * fixed conflicts resolve * improved FindTrackedTimesOptions.ToOptions() method * added backwards compatibility on ListReleases request; fixed issue tracked time ToSession * fixed build error; fixed swagger template * fixed swagger template * fixed ListReleases backwards compatibility * added page to user search route Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
		
				
					committed by
					
						
						techknowlogick
					
				
			
			
				
	
			
			
			
						parent
						
							333401e0fd
						
					
				
				
					commit
					1f01f53c53
				
			@@ -9,8 +9,8 @@ import (
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/models"
 | 
			
		||||
	"code.gitea.io/gitea/modules/context"
 | 
			
		||||
	"code.gitea.io/gitea/modules/setting"
 | 
			
		||||
	api "code.gitea.io/gitea/modules/structs"
 | 
			
		||||
	"code.gitea.io/gitea/routers/api/v1/utils"
 | 
			
		||||
	releaseservice "code.gitea.io/gitea/services/release"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
@@ -59,20 +59,6 @@ func GetRelease(ctx *context.APIContext) {
 | 
			
		||||
	ctx.JSON(http.StatusOK, release.APIFormat())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func getPagesInfo(ctx *context.APIContext) (int, int) {
 | 
			
		||||
	page := ctx.QueryInt("page")
 | 
			
		||||
	if page == 0 {
 | 
			
		||||
		page = 1
 | 
			
		||||
	}
 | 
			
		||||
	perPage := ctx.QueryInt("per_page")
 | 
			
		||||
	if perPage == 0 {
 | 
			
		||||
		perPage = setting.API.DefaultPagingNum
 | 
			
		||||
	} else if perPage > setting.API.MaxResponseItems {
 | 
			
		||||
		perPage = setting.API.MaxResponseItems
 | 
			
		||||
	}
 | 
			
		||||
	return page, perPage
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// ListReleases list a repository's releases
 | 
			
		||||
func ListReleases(ctx *context.APIContext) {
 | 
			
		||||
	// swagger:operation GET /repos/{owner}/{repo}/releases repository repoListReleases
 | 
			
		||||
@@ -91,23 +77,32 @@ func ListReleases(ctx *context.APIContext) {
 | 
			
		||||
	//   description: name of the repo
 | 
			
		||||
	//   type: string
 | 
			
		||||
	//   required: true
 | 
			
		||||
	// - name: page
 | 
			
		||||
	//   in: query
 | 
			
		||||
	//   description: page wants to load
 | 
			
		||||
	//   type: integer
 | 
			
		||||
	// - name: per_page
 | 
			
		||||
	//   in: query
 | 
			
		||||
	//   description: items count every page wants to load
 | 
			
		||||
	//   type: integer
 | 
			
		||||
	//   deprecated: true
 | 
			
		||||
	// - name: page
 | 
			
		||||
	//   in: query
 | 
			
		||||
	//   description: page number of results to return (1-based)
 | 
			
		||||
	//   type: integer
 | 
			
		||||
	// - name: limit
 | 
			
		||||
	//   in: query
 | 
			
		||||
	//   description: page size of results, maximum page size is 50
 | 
			
		||||
	//   type: integer
 | 
			
		||||
	// responses:
 | 
			
		||||
	//   "200":
 | 
			
		||||
	//     "$ref": "#/responses/ReleaseList"
 | 
			
		||||
	listOptions := utils.GetListOptions(ctx)
 | 
			
		||||
	if ctx.QueryInt("per_page") != 0 {
 | 
			
		||||
		listOptions.PageSize = ctx.QueryInt("per_page")
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	page, limit := getPagesInfo(ctx)
 | 
			
		||||
	releases, err := models.GetReleasesByRepoID(ctx.Repo.Repository.ID, models.FindReleasesOptions{
 | 
			
		||||
		ListOptions:   listOptions,
 | 
			
		||||
		IncludeDrafts: ctx.Repo.AccessMode >= models.AccessModeWrite,
 | 
			
		||||
		IncludeTags:   false,
 | 
			
		||||
	}, page, limit)
 | 
			
		||||
	})
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		ctx.Error(http.StatusInternalServerError, "GetReleasesByRepoID", err)
 | 
			
		||||
		return
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user