mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	Remove usage of JS globals (#15378)
Refactor the exported globals in index.js to JS-initialized event handlers. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This commit is contained in:
		@@ -1,5 +1,3 @@
 | 
			
		||||
/* exported deleteDependencyModal, cancelCodeComment, onOAuthLoginClick */
 | 
			
		||||
 | 
			
		||||
import './publicpath.js';
 | 
			
		||||
 | 
			
		||||
import Vue from 'vue';
 | 
			
		||||
@@ -1156,6 +1154,32 @@ async function initRepository() {
 | 
			
		||||
      return false;
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    // Delete Issue dependency
 | 
			
		||||
    $(document).on('click', '.delete-dependency-button', (e) => {
 | 
			
		||||
      const {id, type} = e.currentTarget.dataset;
 | 
			
		||||
 | 
			
		||||
      $('.remove-dependency').modal({
 | 
			
		||||
        closable: false,
 | 
			
		||||
        duration: 200,
 | 
			
		||||
        onApprove: () => {
 | 
			
		||||
          $('#removeDependencyID').val(id);
 | 
			
		||||
          $('#dependencyType').val(type);
 | 
			
		||||
          $('#removeDependencyForm').trigger('submit');
 | 
			
		||||
        }
 | 
			
		||||
      }).modal('show');
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    // Cancel inline code comment
 | 
			
		||||
    $(document).on('click', '.cancel-code-comment', (e) => {
 | 
			
		||||
      const form = $(e.currentTarget).closest('form');
 | 
			
		||||
      if (form.length > 0 && form.hasClass('comment-form')) {
 | 
			
		||||
        form.addClass('hide');
 | 
			
		||||
        form.parent().find('button.comment-form-reply').show();
 | 
			
		||||
      } else {
 | 
			
		||||
        form.closest('.comment-code-cloud').remove();
 | 
			
		||||
      }
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    // Change status
 | 
			
		||||
    const $statusButton = $('#status-button');
 | 
			
		||||
    $('#comment-form textarea').on('keyup', function () {
 | 
			
		||||
@@ -1193,6 +1217,7 @@ async function initRepository() {
 | 
			
		||||
      $mergeButton.parent().show();
 | 
			
		||||
      $('.instruct-toggle').show();
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    initReactionSelector();
 | 
			
		||||
  }
 | 
			
		||||
 | 
			
		||||
@@ -3812,19 +3837,6 @@ function initIssueDue() {
 | 
			
		||||
  });
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
window.deleteDependencyModal = function (id, type) {
 | 
			
		||||
  $('.remove-dependency')
 | 
			
		||||
    .modal({
 | 
			
		||||
      closable: false,
 | 
			
		||||
      duration: 200,
 | 
			
		||||
      onApprove() {
 | 
			
		||||
        $('#removeDependencyID').val(id);
 | 
			
		||||
        $('#dependencyType').val(type);
 | 
			
		||||
        $('#removeDependencyForm').trigger('submit');
 | 
			
		||||
      }
 | 
			
		||||
    }).modal('show');
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
function initIssueList() {
 | 
			
		||||
  const repolink = $('#repolink').val();
 | 
			
		||||
  const repoId = $('#repoId').val();
 | 
			
		||||
@@ -3911,17 +3923,7 @@ $(document).on('submit', '.conversation-holder form', async (e) => {
 | 
			
		||||
  initClipboard();
 | 
			
		||||
});
 | 
			
		||||
 | 
			
		||||
window.cancelCodeComment = function (btn) {
 | 
			
		||||
  const form = $(btn).closest('form');
 | 
			
		||||
  if (form.length > 0 && form.hasClass('comment-form')) {
 | 
			
		||||
    form.addClass('hide');
 | 
			
		||||
    form.parent().find('button.comment-form-reply').show();
 | 
			
		||||
  } else {
 | 
			
		||||
    form.closest('.comment-code-cloud').remove();
 | 
			
		||||
  }
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
window.onOAuthLoginClick = function () {
 | 
			
		||||
$(document).on('click', '.oauth-login-image', () => {
 | 
			
		||||
  const oauthLoader = $('#oauth2-login-loader');
 | 
			
		||||
  const oauthNav = $('#oauth2-login-navigator');
 | 
			
		||||
 | 
			
		||||
@@ -3934,4 +3936,4 @@ window.onOAuthLoginClick = function () {
 | 
			
		||||
    oauthLoader.addClass('disabled');
 | 
			
		||||
    oauthNav.show();
 | 
			
		||||
  }, 5000);
 | 
			
		||||
};
 | 
			
		||||
});
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user