mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Move keys to models/asymkey (#17917)
* Move keys to models/keys * Rename models/keys -> models/asymkey * change the missed package name * Fix package alias * Fix test * Fix docs * Fix test * Fix test * merge
This commit is contained in:
		@@ -9,7 +9,7 @@ import (
 | 
			
		||||
	"net/http"
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/models"
 | 
			
		||||
	asymkey_model "code.gitea.io/gitea/models/asymkey"
 | 
			
		||||
	"code.gitea.io/gitea/models/unittest"
 | 
			
		||||
	user_model "code.gitea.io/gitea/models/user"
 | 
			
		||||
	"code.gitea.io/gitea/modules/json"
 | 
			
		||||
@@ -34,7 +34,7 @@ func TestAPIAdminCreateAndDeleteSSHKey(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	var newPublicKey api.PublicKey
 | 
			
		||||
	DecodeJSON(t, resp, &newPublicKey)
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &models.PublicKey{
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &asymkey_model.PublicKey{
 | 
			
		||||
		ID:          newPublicKey.ID,
 | 
			
		||||
		Name:        newPublicKey.Title,
 | 
			
		||||
		Content:     newPublicKey.Key,
 | 
			
		||||
@@ -45,7 +45,7 @@ func TestAPIAdminCreateAndDeleteSSHKey(t *testing.T) {
 | 
			
		||||
	req = NewRequestf(t, "DELETE", "/api/v1/admin/users/%s/keys/%d?token=%s",
 | 
			
		||||
		keyOwner.Name, newPublicKey.ID, token)
 | 
			
		||||
	session.MakeRequest(t, req, http.StatusNoContent)
 | 
			
		||||
	unittest.AssertNotExistsBean(t, &models.PublicKey{ID: newPublicKey.ID})
 | 
			
		||||
	unittest.AssertNotExistsBean(t, &asymkey_model.PublicKey{ID: newPublicKey.ID})
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestAPIAdminDeleteMissingSSHKey(t *testing.T) {
 | 
			
		||||
 
 | 
			
		||||
@@ -10,7 +10,7 @@ import (
 | 
			
		||||
	"net/url"
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/models"
 | 
			
		||||
	asymkey_model "code.gitea.io/gitea/models/asymkey"
 | 
			
		||||
	"code.gitea.io/gitea/models/perm"
 | 
			
		||||
	repo_model "code.gitea.io/gitea/models/repo"
 | 
			
		||||
	"code.gitea.io/gitea/models/unittest"
 | 
			
		||||
@@ -65,7 +65,7 @@ func TestCreateReadOnlyDeployKey(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	var newDeployKey api.DeployKey
 | 
			
		||||
	DecodeJSON(t, resp, &newDeployKey)
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &models.DeployKey{
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &asymkey_model.DeployKey{
 | 
			
		||||
		ID:      newDeployKey.ID,
 | 
			
		||||
		Name:    rawKeyBody.Title,
 | 
			
		||||
		Content: rawKeyBody.Key,
 | 
			
		||||
@@ -90,7 +90,7 @@ func TestCreateReadWriteDeployKey(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	var newDeployKey api.DeployKey
 | 
			
		||||
	DecodeJSON(t, resp, &newDeployKey)
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &models.DeployKey{
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &asymkey_model.DeployKey{
 | 
			
		||||
		ID:      newDeployKey.ID,
 | 
			
		||||
		Name:    rawKeyBody.Title,
 | 
			
		||||
		Content: rawKeyBody.Key,
 | 
			
		||||
@@ -116,7 +116,7 @@ func TestCreateUserKey(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	var newPublicKey api.PublicKey
 | 
			
		||||
	DecodeJSON(t, resp, &newPublicKey)
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &models.PublicKey{
 | 
			
		||||
	unittest.AssertExistsAndLoadBean(t, &asymkey_model.PublicKey{
 | 
			
		||||
		ID:      newPublicKey.ID,
 | 
			
		||||
		OwnerID: user.ID,
 | 
			
		||||
		Name:    rawKeyBody.Title,
 | 
			
		||||
 
 | 
			
		||||
@@ -9,7 +9,7 @@ import (
 | 
			
		||||
	"net/url"
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/models"
 | 
			
		||||
	asymkey_model "code.gitea.io/gitea/models/asymkey"
 | 
			
		||||
	"code.gitea.io/gitea/models/perm"
 | 
			
		||||
	"code.gitea.io/gitea/modules/private"
 | 
			
		||||
 | 
			
		||||
@@ -27,7 +27,7 @@ func TestAPIPrivateNoServ(t *testing.T) {
 | 
			
		||||
		assert.Equal(t, int64(1), key.ID)
 | 
			
		||||
		assert.Equal(t, "user2@localhost", key.Name)
 | 
			
		||||
 | 
			
		||||
		deployKey, err := models.AddDeployKey(1, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", false)
 | 
			
		||||
		deployKey, err := asymkey_model.AddDeployKey(1, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", false)
 | 
			
		||||
		assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
		key, user, err = private.ServNoCommand(ctx, deployKey.KeyID)
 | 
			
		||||
@@ -85,7 +85,7 @@ func TestAPIPrivateServ(t *testing.T) {
 | 
			
		||||
		assert.Empty(t, results)
 | 
			
		||||
 | 
			
		||||
		// Add reading deploy key
 | 
			
		||||
		deployKey, err := models.AddDeployKey(19, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", true)
 | 
			
		||||
		deployKey, err := asymkey_model.AddDeployKey(19, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", true)
 | 
			
		||||
		assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
		// Can pull from repo we're a deploy key for
 | 
			
		||||
@@ -117,7 +117,7 @@ func TestAPIPrivateServ(t *testing.T) {
 | 
			
		||||
		assert.Empty(t, results)
 | 
			
		||||
 | 
			
		||||
		// Add writing deploy key
 | 
			
		||||
		deployKey, err = models.AddDeployKey(20, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", false)
 | 
			
		||||
		deployKey, err = asymkey_model.AddDeployKey(20, "test-deploy", "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment", false)
 | 
			
		||||
		assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
		// Cannot push to a private repo with reading key
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user