mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	Return 404 when user is not found on avatar (#21476)
- Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found
This commit is contained in:
		@@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
 | 
				
			|||||||
	if strings.ToLower(userName) != "ghost" {
 | 
						if strings.ToLower(userName) != "ghost" {
 | 
				
			||||||
		var err error
 | 
							var err error
 | 
				
			||||||
		if user, err = user_model.GetUserByName(ctx, userName); err != nil {
 | 
							if user, err = user_model.GetUserByName(ctx, userName); err != nil {
 | 
				
			||||||
 | 
								if user_model.IsErrUserNotExist(err) {
 | 
				
			||||||
 | 
									ctx.NotFound("GetUserByName", err)
 | 
				
			||||||
 | 
									return
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
			ctx.ServerError("Invalid user: "+userName, err)
 | 
								ctx.ServerError("Invalid user: "+userName, err)
 | 
				
			||||||
			return
 | 
								return
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user