mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	Make better use of i18n (#20096)
* Prototyping * Start work on creating offsets * Modify tests * Start prototyping with actual MPH * Twiddle around * Twiddle around comments * Convert templates * Fix external languages * Fix latest translation * Fix some test * Tidy up code * Use simple map * go mod tidy * Move back to data structure - Uses less memory by creating for each language a map. * Apply suggestions from code review Co-authored-by: delvh <dev.lh@web.de> * Add some comments * Fix tests * Try to fix tests * Use en-US as defacto fallback * Use correct slices * refactor (#4) * Remove TryTr, add log for missing translation key * Refactor i18n - Separate dev and production locale stores. - Allow for live-reloading in dev mode. Co-authored-by: zeripath <art27@cantab.net> * Fix live-reloading & check for errors * Make linter happy * live-reload with periodic check (#5) * Fix tests Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
		@@ -7,7 +7,7 @@ package cron
 | 
			
		||||
import (
 | 
			
		||||
	"time"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/modules/translation/i18n"
 | 
			
		||||
	"code.gitea.io/gitea/modules/translation"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
// Config represents a basic configuration interface that cron task
 | 
			
		||||
@@ -15,7 +15,7 @@ type Config interface {
 | 
			
		||||
	IsEnabled() bool
 | 
			
		||||
	DoRunAtStart() bool
 | 
			
		||||
	GetSchedule() string
 | 
			
		||||
	FormatMessage(locale, name, status, doer string, args ...interface{}) string
 | 
			
		||||
	FormatMessage(locale translation.Locale, name, status, doer string, args ...interface{}) string
 | 
			
		||||
	DoNoticeOnSuccess() bool
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
@@ -69,9 +69,9 @@ func (b *BaseConfig) DoNoticeOnSuccess() bool {
 | 
			
		||||
 | 
			
		||||
// FormatMessage returns a message for the task
 | 
			
		||||
// Please note the `status` string will be concatenated with `admin.dashboard.cron.` and `admin.dashboard.task.` to provide locale messages. Similarly `name` will be composed with `admin.dashboard.` to provide the locale name for the task.
 | 
			
		||||
func (b *BaseConfig) FormatMessage(locale, name, status, doer string, args ...interface{}) string {
 | 
			
		||||
func (b *BaseConfig) FormatMessage(locale translation.Locale, name, status, doer string, args ...interface{}) string {
 | 
			
		||||
	realArgs := make([]interface{}, 0, len(args)+2)
 | 
			
		||||
	realArgs = append(realArgs, i18n.Tr(locale, "admin.dashboard."+name))
 | 
			
		||||
	realArgs = append(realArgs, locale.Tr("admin.dashboard."+name))
 | 
			
		||||
	if doer == "" {
 | 
			
		||||
		realArgs = append(realArgs, "(Cron)")
 | 
			
		||||
	} else {
 | 
			
		||||
@@ -81,7 +81,7 @@ func (b *BaseConfig) FormatMessage(locale, name, status, doer string, args ...in
 | 
			
		||||
		realArgs = append(realArgs, args...)
 | 
			
		||||
	}
 | 
			
		||||
	if doer == "" {
 | 
			
		||||
		return i18n.Tr(locale, "admin.dashboard.cron."+status, realArgs...)
 | 
			
		||||
		return locale.Tr("admin.dashboard.cron."+status, realArgs...)
 | 
			
		||||
	}
 | 
			
		||||
	return i18n.Tr(locale, "admin.dashboard.task."+status, realArgs...)
 | 
			
		||||
	return locale.Tr("admin.dashboard.task."+status, realArgs...)
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user