mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	* Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
This commit is contained in:
		
							
								
								
									
										247
									
								
								modules/log/file_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										247
									
								
								modules/log/file_test.go
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,247 @@
 | 
			
		||||
// Copyright 2019 The Gitea Authors. All rights reserved.
 | 
			
		||||
// Use of this source code is governed by a MIT-style
 | 
			
		||||
// license that can be found in the LICENSE file.
 | 
			
		||||
 | 
			
		||||
package log
 | 
			
		||||
 | 
			
		||||
import (
 | 
			
		||||
	"compress/gzip"
 | 
			
		||||
	"fmt"
 | 
			
		||||
	"io/ioutil"
 | 
			
		||||
	"os"
 | 
			
		||||
	"path/filepath"
 | 
			
		||||
	"strings"
 | 
			
		||||
	"testing"
 | 
			
		||||
	"time"
 | 
			
		||||
 | 
			
		||||
	"github.com/stretchr/testify/assert"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
func TestFileLoggerFails(t *testing.T) {
 | 
			
		||||
	tmpDir, err := ioutil.TempDir("", "TestFileLogger")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	defer os.RemoveAll(tmpDir)
 | 
			
		||||
 | 
			
		||||
	prefix := "TestPrefix "
 | 
			
		||||
	level := INFO
 | 
			
		||||
	flags := LstdFlags | LUTC | Lfuncname
 | 
			
		||||
	//filename := filepath.Join(tmpDir, "test.log")
 | 
			
		||||
 | 
			
		||||
	fileLogger := NewFileLogger()
 | 
			
		||||
	//realFileLogger, ok := fileLogger.(*FileLogger)
 | 
			
		||||
	//assert.Equal(t, true, ok)
 | 
			
		||||
 | 
			
		||||
	// Fail if there is bad json
 | 
			
		||||
	err = fileLogger.Init("{")
 | 
			
		||||
	assert.Error(t, err)
 | 
			
		||||
 | 
			
		||||
	// Fail if there is no filename
 | 
			
		||||
	err = fileLogger.Init(fmt.Sprintf("{\"prefix\":\"%s\",\"level\":\"%s\",\"flags\":%d,\"filename\":\"%s\"}", prefix, level.String(), flags, ""))
 | 
			
		||||
	assert.Error(t, err)
 | 
			
		||||
 | 
			
		||||
	// Fail if the file isn't a filename
 | 
			
		||||
	err = fileLogger.Init(fmt.Sprintf("{\"prefix\":\"%s\",\"level\":\"%s\",\"flags\":%d,\"filename\":\"%s\"}", prefix, level.String(), flags, filepath.ToSlash(tmpDir)))
 | 
			
		||||
	assert.Error(t, err)
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestFileLogger(t *testing.T) {
 | 
			
		||||
	tmpDir, err := ioutil.TempDir("", "TestFileLogger")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	defer os.RemoveAll(tmpDir)
 | 
			
		||||
 | 
			
		||||
	prefix := "TestPrefix "
 | 
			
		||||
	level := INFO
 | 
			
		||||
	flags := LstdFlags | LUTC | Lfuncname
 | 
			
		||||
	filename := filepath.Join(tmpDir, "test.log")
 | 
			
		||||
 | 
			
		||||
	fileLogger := NewFileLogger()
 | 
			
		||||
	realFileLogger, ok := fileLogger.(*FileLogger)
 | 
			
		||||
	assert.Equal(t, true, ok)
 | 
			
		||||
 | 
			
		||||
	location, _ := time.LoadLocation("EST")
 | 
			
		||||
 | 
			
		||||
	date := time.Date(2019, time.January, 13, 22, 3, 30, 15, location)
 | 
			
		||||
 | 
			
		||||
	dateString := date.UTC().Format("2006/01/02 15:04:05")
 | 
			
		||||
 | 
			
		||||
	event := Event{
 | 
			
		||||
		level:    INFO,
 | 
			
		||||
		msg:      "TEST MSG",
 | 
			
		||||
		caller:   "CALLER",
 | 
			
		||||
		filename: "FULL/FILENAME",
 | 
			
		||||
		line:     1,
 | 
			
		||||
		time:     date,
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	expected := fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
 | 
			
		||||
	fileLogger.Init(fmt.Sprintf("{\"prefix\":\"%s\",\"level\":\"%s\",\"flags\":%d,\"filename\":\"%s\",\"maxsize\":%d,\"compress\":false}", prefix, level.String(), flags, filepath.ToSlash(filename), len(expected)*2))
 | 
			
		||||
 | 
			
		||||
	assert.Equal(t, flags, realFileLogger.Flags)
 | 
			
		||||
	assert.Equal(t, level, realFileLogger.Level)
 | 
			
		||||
	assert.Equal(t, level, fileLogger.GetLevel())
 | 
			
		||||
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err := ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	event.level = DEBUG
 | 
			
		||||
	expected = expected + ""
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	event.level = TRACE
 | 
			
		||||
	expected = expected + ""
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	event.level = WARN
 | 
			
		||||
	expected = expected + fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	// Should rotate
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename + fmt.Sprintf(".%s.%03d", time.Now().Format("2006-01-02"), 1))
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	expected = fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	for num := 2; num <= 999; num++ {
 | 
			
		||||
		file, err := os.OpenFile(filename+fmt.Sprintf(".%s.%03d", time.Now().Format("2006-01-02"), num), os.O_RDONLY|os.O_CREATE, 0666)
 | 
			
		||||
		assert.NoError(t, err)
 | 
			
		||||
		file.Close()
 | 
			
		||||
	}
 | 
			
		||||
	err = realFileLogger.DoRotate()
 | 
			
		||||
	assert.Error(t, err)
 | 
			
		||||
 | 
			
		||||
	expected = expected + fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	// Should fail to rotate
 | 
			
		||||
	expected = expected + fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	fileLogger.Close()
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestCompressFileLogger(t *testing.T) {
 | 
			
		||||
	tmpDir, err := ioutil.TempDir("", "TestFileLogger")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	defer os.RemoveAll(tmpDir)
 | 
			
		||||
 | 
			
		||||
	prefix := "TestPrefix "
 | 
			
		||||
	level := INFO
 | 
			
		||||
	flags := LstdFlags | LUTC | Lfuncname
 | 
			
		||||
	filename := filepath.Join(tmpDir, "test.log")
 | 
			
		||||
 | 
			
		||||
	fileLogger := NewFileLogger()
 | 
			
		||||
	realFileLogger, ok := fileLogger.(*FileLogger)
 | 
			
		||||
	assert.Equal(t, true, ok)
 | 
			
		||||
 | 
			
		||||
	location, _ := time.LoadLocation("EST")
 | 
			
		||||
 | 
			
		||||
	date := time.Date(2019, time.January, 13, 22, 3, 30, 15, location)
 | 
			
		||||
 | 
			
		||||
	dateString := date.UTC().Format("2006/01/02 15:04:05")
 | 
			
		||||
 | 
			
		||||
	event := Event{
 | 
			
		||||
		level:    INFO,
 | 
			
		||||
		msg:      "TEST MSG",
 | 
			
		||||
		caller:   "CALLER",
 | 
			
		||||
		filename: "FULL/FILENAME",
 | 
			
		||||
		line:     1,
 | 
			
		||||
		time:     date,
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	expected := fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
 | 
			
		||||
	fileLogger.Init(fmt.Sprintf("{\"prefix\":\"%s\",\"level\":\"%s\",\"flags\":%d,\"filename\":\"%s\",\"maxsize\":%d,\"compress\":true}", prefix, level.String(), flags, filepath.ToSlash(filename), len(expected)*2))
 | 
			
		||||
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err := ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	event.level = WARN
 | 
			
		||||
	expected = expected + fmt.Sprintf("%s%s %s:%d:%s [%c] %s\n", prefix, dateString, event.filename, event.line, event.caller, strings.ToUpper(event.level.String())[0], event.msg)
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
	logData, err = ioutil.ReadFile(filename)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, expected, string(logData))
 | 
			
		||||
 | 
			
		||||
	// Should rotate
 | 
			
		||||
	fileLogger.LogEvent(&event)
 | 
			
		||||
	fileLogger.Flush()
 | 
			
		||||
 | 
			
		||||
	for num := 2; num <= 999; num++ {
 | 
			
		||||
		file, err := os.OpenFile(filename+fmt.Sprintf(".%s.%03d.gz", time.Now().Format("2006-01-02"), num), os.O_RDONLY|os.O_CREATE, 0666)
 | 
			
		||||
		assert.NoError(t, err)
 | 
			
		||||
		file.Close()
 | 
			
		||||
	}
 | 
			
		||||
	err = realFileLogger.DoRotate()
 | 
			
		||||
	assert.Error(t, err)
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestCompressOldFile(t *testing.T) {
 | 
			
		||||
	tmpDir, err := ioutil.TempDir("", "TestFileLogger")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	defer os.RemoveAll(tmpDir)
 | 
			
		||||
	fname := filepath.Join(tmpDir, "test")
 | 
			
		||||
	nonGzip := filepath.Join(tmpDir, "test-nonGzip")
 | 
			
		||||
 | 
			
		||||
	f, err := os.OpenFile(fname, os.O_CREATE|os.O_WRONLY, 0660)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	ng, err := os.OpenFile(nonGzip, os.O_CREATE|os.O_WRONLY, 0660)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	for i := 0; i < 999; i++ {
 | 
			
		||||
		f.WriteString("This is a test file\n")
 | 
			
		||||
		ng.WriteString("This is a test file\n")
 | 
			
		||||
	}
 | 
			
		||||
	f.Close()
 | 
			
		||||
	ng.Close()
 | 
			
		||||
 | 
			
		||||
	err = compressOldLogFile(fname, -1)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	_, err = os.Lstat(fname + ".gz")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	f, err = os.Open(fname + ".gz")
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	zr, err := gzip.NewReader(f)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	data, err := ioutil.ReadAll(zr)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	original, err := ioutil.ReadFile(nonGzip)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.Equal(t, original, data)
 | 
			
		||||
}
 | 
			
		||||
		Reference in New Issue
	
	Block a user