mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Re-attempt to delete temporary upload if the file is locked by another process (#12447)
Replace all calls to os.Remove/os.RemoveAll by retrying util.Remove/util.RemoveAll and remove circular dependencies from util. Fix #12339 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
		@@ -10,6 +10,7 @@ import (
 | 
			
		||||
	"strconv"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/modules/log"
 | 
			
		||||
	"code.gitea.io/gitea/modules/util"
 | 
			
		||||
	"github.com/blevesearch/bleve"
 | 
			
		||||
	"github.com/blevesearch/bleve/analysis/analyzer/custom"
 | 
			
		||||
	"github.com/blevesearch/bleve/analysis/token/lowercase"
 | 
			
		||||
@@ -86,14 +87,14 @@ func openIndexer(path string, latestVersion int) (bleve.Index, error) {
 | 
			
		||||
	if metadata.Version < latestVersion {
 | 
			
		||||
		// the indexer is using a previous version, so we should delete it and
 | 
			
		||||
		// re-populate
 | 
			
		||||
		return nil, os.RemoveAll(path)
 | 
			
		||||
		return nil, util.RemoveAll(path)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	index, err := bleve.Open(path)
 | 
			
		||||
	if err != nil && err == upsidedown.IncompatibleVersion {
 | 
			
		||||
		// the indexer was built with a previous version of bleve, so we should
 | 
			
		||||
		// delete it and re-populate
 | 
			
		||||
		return nil, os.RemoveAll(path)
 | 
			
		||||
		return nil, util.RemoveAll(path)
 | 
			
		||||
	} else if err != nil {
 | 
			
		||||
		return nil, err
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user