mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	#2852 code cleanup
This commit is contained in:
		@@ -3,7 +3,7 @@ Gogs - Go Git Service [
 | 
			
		||||
 | 
			
		||||
##### Current tip version: 0.9.73 (see [Releases](https://github.com/gogits/gogs/releases) for binary versions)
 | 
			
		||||
##### Current tip version: 0.9.74 (see [Releases](https://github.com/gogits/gogs/releases) for binary versions)
 | 
			
		||||
 | 
			
		||||
| Web | UI  | Preview  |
 | 
			
		||||
|:-------------:|:-------:|:-------:|
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										26
									
								
								cmd/web.go
									
									
									
									
									
								
							
							
						
						
									
										26
									
								
								cmd/web.go
									
									
									
									
									
								
							@@ -577,16 +577,19 @@ func runWeb(ctx *cli.Context) error {
 | 
			
		||||
 | 
			
		||||
	// Flag for port number in case first time run conflict.
 | 
			
		||||
	if ctx.IsSet("port") {
 | 
			
		||||
		setting.AppUrl = strings.Replace(setting.AppUrl, setting.HttpPort, ctx.String("port"), 1)
 | 
			
		||||
		setting.HttpPort = ctx.String("port")
 | 
			
		||||
		setting.AppUrl = strings.Replace(setting.AppUrl, setting.HTTPPort, ctx.String("port"), 1)
 | 
			
		||||
		setting.HTTPPort = ctx.String("port")
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	var err error
 | 
			
		||||
	listenAddr := fmt.Sprintf("%s:%s", setting.HttpAddr, setting.HttpPort)
 | 
			
		||||
	var listenAddr string
 | 
			
		||||
	if setting.Protocol == setting.UNIX_SOCKET {
 | 
			
		||||
		listenAddr = fmt.Sprintf("%s", setting.HttpAddr)
 | 
			
		||||
		listenAddr = fmt.Sprintf("%s", setting.HTTPAddr)
 | 
			
		||||
	} else {
 | 
			
		||||
		listenAddr = fmt.Sprintf("%s:%s", setting.HTTPAddr, setting.HTTPPort)
 | 
			
		||||
	}
 | 
			
		||||
	log.Info("Listen: %v://%s%s", setting.Protocol, listenAddr, setting.AppSubUrl)
 | 
			
		||||
 | 
			
		||||
	var err error
 | 
			
		||||
	switch setting.Protocol {
 | 
			
		||||
	case setting.HTTP:
 | 
			
		||||
		err = http.ListenAndServe(listenAddr, m)
 | 
			
		||||
@@ -597,18 +600,19 @@ func runWeb(ctx *cli.Context) error {
 | 
			
		||||
		err = fcgi.Serve(nil, m)
 | 
			
		||||
	case setting.UNIX_SOCKET:
 | 
			
		||||
		os.Remove(listenAddr)
 | 
			
		||||
		listener, err := net.ListenUnix("unix", &net.UnixAddr{listenAddr, "unix"})
 | 
			
		||||
 | 
			
		||||
		var listener *net.UnixListener
 | 
			
		||||
		listener, err = net.ListenUnix("unix", &net.UnixAddr{listenAddr, "unix"})
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			break
 | 
			
		||||
			break // Handle error after switch
 | 
			
		||||
		}
 | 
			
		||||
		// FIXME add proper implementation of signal capture on all protocols
 | 
			
		||||
 | 
			
		||||
		// FIXME: add proper implementation of signal capture on all protocols
 | 
			
		||||
		// execute this on SIGTERM or SIGINT: listener.Close()
 | 
			
		||||
		err = os.Chmod(listenAddr, os.FileMode(setting.UnixSocketPermission))
 | 
			
		||||
		if err != nil {
 | 
			
		||||
		if err = os.Chmod(listenAddr, os.FileMode(setting.UnixSocketPermission)); err != nil {
 | 
			
		||||
			log.Fatal(4, "Failed to set permission of unix socket: %v", err)
 | 
			
		||||
		}
 | 
			
		||||
		err = http.Serve(listener, m)
 | 
			
		||||
 | 
			
		||||
	default:
 | 
			
		||||
		log.Fatal(4, "Invalid protocol: %s", setting.Protocol)
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										2
									
								
								gogs.go
									
									
									
									
									
								
							
							
						
						
									
										2
									
								
								gogs.go
									
									
									
									
									
								
							@@ -17,7 +17,7 @@ import (
 | 
			
		||||
	"github.com/gogits/gogs/modules/setting"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
const APP_VER = "0.9.73.0811"
 | 
			
		||||
const APP_VER = "0.9.74.0811"
 | 
			
		||||
 | 
			
		||||
func init() {
 | 
			
		||||
	runtime.GOMAXPROCS(runtime.NumCPU())
 | 
			
		||||
 
 | 
			
		||||
										
											
												File diff suppressed because one or more lines are too long
											
										
									
								
							@@ -62,7 +62,7 @@ var (
 | 
			
		||||
	// Server settings
 | 
			
		||||
	Protocol             Scheme
 | 
			
		||||
	Domain               string
 | 
			
		||||
	HttpAddr, HttpPort   string
 | 
			
		||||
	HTTPAddr, HTTPPort   string
 | 
			
		||||
	LocalURL             string
 | 
			
		||||
	OfflineMode          bool
 | 
			
		||||
	DisableRouterLog     bool
 | 
			
		||||
@@ -372,17 +372,17 @@ func NewContext() {
 | 
			
		||||
		Protocol = FCGI
 | 
			
		||||
	} else if sec.Key("PROTOCOL").String() == "unix" {
 | 
			
		||||
		Protocol = UNIX_SOCKET
 | 
			
		||||
		UnixSocketPermissionRaw := sec.Key("UNIX_SOCKET_PERMISSION").MustString("666")
 | 
			
		||||
		UnixSocketPermissionParsed, err := strconv.ParseUint(UnixSocketPermissionRaw, 8, 32)
 | 
			
		||||
		if err != nil || UnixSocketPermissionParsed > 0777 {
 | 
			
		||||
			log.Fatal(4, "Fail to parse unixSocketPermission: %s", UnixSocketPermissionRaw)
 | 
			
		||||
		}
 | 
			
		||||
		UnixSocketPermission = uint32(UnixSocketPermissionParsed)
 | 
			
		||||
	}
 | 
			
		||||
	Domain = sec.Key("DOMAIN").MustString("localhost")
 | 
			
		||||
	HttpAddr = sec.Key("HTTP_ADDR").MustString("0.0.0.0")
 | 
			
		||||
	HttpPort = sec.Key("HTTP_PORT").MustString("3000")
 | 
			
		||||
	LocalURL = sec.Key("LOCAL_ROOT_URL").MustString(string(Protocol) + "://localhost:" + HttpPort + "/")
 | 
			
		||||
	UnixSocketPermissionRaw := sec.Key("UNIX_SOCKET_PERMISSION").MustString("666")
 | 
			
		||||
	UnixSocketPermissionParsed, err := strconv.ParseUint(UnixSocketPermissionRaw, 8, 32)
 | 
			
		||||
	if err != nil || UnixSocketPermissionParsed > 0777 {
 | 
			
		||||
		log.Fatal(4, "Fail to parse unixSocketPermission: %s", UnixSocketPermissionRaw)
 | 
			
		||||
	}
 | 
			
		||||
	UnixSocketPermission = uint32(UnixSocketPermissionParsed)
 | 
			
		||||
	HTTPAddr = sec.Key("HTTP_ADDR").MustString("0.0.0.0")
 | 
			
		||||
	HTTPPort = sec.Key("HTTP_PORT").MustString("3000")
 | 
			
		||||
	LocalURL = sec.Key("LOCAL_ROOT_URL").MustString(string(Protocol) + "://localhost:" + HTTPPort + "/")
 | 
			
		||||
	OfflineMode = sec.Key("OFFLINE_MODE").MustBool()
 | 
			
		||||
	DisableRouterLog = sec.Key("DISABLE_ROUTER_LOG").MustBool()
 | 
			
		||||
	StaticRootPath = sec.Key("STATIC_ROOT_PATH").MustString(workDir)
 | 
			
		||||
 
 | 
			
		||||
@@ -153,7 +153,7 @@ func Install(ctx *context.Context) {
 | 
			
		||||
 | 
			
		||||
	form.Domain = setting.Domain
 | 
			
		||||
	form.SSHPort = setting.SSH.Port
 | 
			
		||||
	form.HTTPPort = setting.HttpPort
 | 
			
		||||
	form.HTTPPort = setting.HTTPPort
 | 
			
		||||
	form.AppUrl = setting.AppUrl
 | 
			
		||||
	form.LogRootPath = setting.LogRootPath
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -1 +1 @@
 | 
			
		||||
0.9.73.0811
 | 
			
		||||
0.9.74.0811
 | 
			
		||||
		Reference in New Issue
	
	Block a user