mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	Move db related basic functions to models/db (#17075)
* Move db related basic functions to models/db * Fix lint * Fix lint * Fix test * Fix lint * Fix lint * revert unnecessary change * Fix test * Fix wrong replace string * Use *Context * Correct committer spelling and fix wrong replaced words Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
		@@ -10,6 +10,7 @@ import (
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/models"
 | 
			
		||||
	"code.gitea.io/gitea/models/db"
 | 
			
		||||
	api "code.gitea.io/gitea/modules/structs"
 | 
			
		||||
 | 
			
		||||
	"github.com/stretchr/testify/assert"
 | 
			
		||||
@@ -25,7 +26,7 @@ func TestOAuth2Application(t *testing.T) {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func testAPICreateOAuth2Application(t *testing.T) {
 | 
			
		||||
	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	user := db.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	appBody := api.CreateOAuth2ApplicationOptions{
 | 
			
		||||
		Name: "test-app-1",
 | 
			
		||||
		RedirectURIs: []string{
 | 
			
		||||
@@ -45,15 +46,15 @@ func testAPICreateOAuth2Application(t *testing.T) {
 | 
			
		||||
	assert.Len(t, createdApp.ClientID, 36)
 | 
			
		||||
	assert.NotEmpty(t, createdApp.Created)
 | 
			
		||||
	assert.EqualValues(t, appBody.RedirectURIs[0], createdApp.RedirectURIs[0])
 | 
			
		||||
	models.AssertExistsAndLoadBean(t, &models.OAuth2Application{UID: user.ID, Name: createdApp.Name})
 | 
			
		||||
	db.AssertExistsAndLoadBean(t, &models.OAuth2Application{UID: user.ID, Name: createdApp.Name})
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func testAPIListOAuth2Applications(t *testing.T) {
 | 
			
		||||
	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	user := db.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	session := loginUser(t, user.Name)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
 | 
			
		||||
	existApp := models.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
	existApp := db.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
		UID:  user.ID,
 | 
			
		||||
		Name: "test-app-1",
 | 
			
		||||
		RedirectURIs: []string{
 | 
			
		||||
@@ -74,15 +75,15 @@ func testAPIListOAuth2Applications(t *testing.T) {
 | 
			
		||||
	assert.Len(t, expectedApp.ClientID, 36)
 | 
			
		||||
	assert.Empty(t, expectedApp.ClientSecret)
 | 
			
		||||
	assert.EqualValues(t, existApp.RedirectURIs[0], expectedApp.RedirectURIs[0])
 | 
			
		||||
	models.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
	db.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func testAPIDeleteOAuth2Application(t *testing.T) {
 | 
			
		||||
	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	user := db.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	session := loginUser(t, user.Name)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
 | 
			
		||||
	oldApp := models.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
	oldApp := db.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
		UID:  user.ID,
 | 
			
		||||
		Name: "test-app-1",
 | 
			
		||||
	}).(*models.OAuth2Application)
 | 
			
		||||
@@ -91,7 +92,7 @@ func testAPIDeleteOAuth2Application(t *testing.T) {
 | 
			
		||||
	req := NewRequest(t, "DELETE", urlStr)
 | 
			
		||||
	session.MakeRequest(t, req, http.StatusNoContent)
 | 
			
		||||
 | 
			
		||||
	models.AssertNotExistsBean(t, &models.OAuth2Application{UID: oldApp.UID, Name: oldApp.Name})
 | 
			
		||||
	db.AssertNotExistsBean(t, &models.OAuth2Application{UID: oldApp.UID, Name: oldApp.Name})
 | 
			
		||||
 | 
			
		||||
	// Delete again will return not found
 | 
			
		||||
	req = NewRequest(t, "DELETE", urlStr)
 | 
			
		||||
@@ -99,11 +100,11 @@ func testAPIDeleteOAuth2Application(t *testing.T) {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func testAPIGetOAuth2Application(t *testing.T) {
 | 
			
		||||
	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	user := db.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	session := loginUser(t, user.Name)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
 | 
			
		||||
	existApp := models.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
	existApp := db.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
		UID:  user.ID,
 | 
			
		||||
		Name: "test-app-1",
 | 
			
		||||
		RedirectURIs: []string{
 | 
			
		||||
@@ -125,13 +126,13 @@ func testAPIGetOAuth2Application(t *testing.T) {
 | 
			
		||||
	assert.Empty(t, expectedApp.ClientSecret)
 | 
			
		||||
	assert.Len(t, expectedApp.RedirectURIs, 1)
 | 
			
		||||
	assert.EqualValues(t, existApp.RedirectURIs[0], expectedApp.RedirectURIs[0])
 | 
			
		||||
	models.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
	db.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func testAPIUpdateOAuth2Application(t *testing.T) {
 | 
			
		||||
	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
	user := db.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | 
			
		||||
 | 
			
		||||
	existApp := models.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
	existApp := db.AssertExistsAndLoadBean(t, &models.OAuth2Application{
 | 
			
		||||
		UID:  user.ID,
 | 
			
		||||
		Name: "test-app-1",
 | 
			
		||||
		RedirectURIs: []string{
 | 
			
		||||
@@ -159,5 +160,5 @@ func testAPIUpdateOAuth2Application(t *testing.T) {
 | 
			
		||||
	assert.Len(t, expectedApp.RedirectURIs, 2)
 | 
			
		||||
	assert.EqualValues(t, expectedApp.RedirectURIs[0], appBody.RedirectURIs[0])
 | 
			
		||||
	assert.EqualValues(t, expectedApp.RedirectURIs[1], appBody.RedirectURIs[1])
 | 
			
		||||
	models.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
	db.AssertExistsAndLoadBean(t, &models.OAuth2Application{ID: expectedApp.ID, Name: expectedApp.Name})
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user