mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Add LFS Migration and Mirror (#14726)
* Implemented LFS client. * Implemented scanning for pointer files. * Implemented downloading of lfs files. * Moved model-dependent code into services. * Removed models dependency. Added TryReadPointerFromBuffer. * Migrated code from service to module. * Centralised storage creation. * Removed dependency from models. * Moved ContentStore into modules. * Share structs between server and client. * Moved method to services. * Implemented lfs download on clone. * Implemented LFS sync on clone and mirror update. * Added form fields. * Updated templates. * Fixed condition. * Use alternate endpoint. * Added missing methods. * Fixed typo and make linter happy. * Detached pointer parser from gogit dependency. * Fixed TestGetLFSRange test. * Added context to support cancellation. * Use ReadFull to probably read more data. * Removed duplicated code from models. * Moved scan implementation into pointer_scanner_nogogit. * Changed method name. * Added comments. * Added more/specific log/error messages. * Embedded lfs.Pointer into models.LFSMetaObject. * Moved code from models to module. * Moved code from models to module. * Moved code from models to module. * Reduced pointer usage. * Embedded type. * Use promoted fields. * Fixed unexpected eof. * Added unit tests. * Implemented migration of local file paths. * Show an error on invalid LFS endpoints. * Hide settings if not used. * Added LFS info to mirror struct. * Fixed comment. * Check LFS endpoint. * Manage LFS settings from mirror page. * Fixed selector. * Adjusted selector. * Added more tests. * Added local filesystem migration test. * Fixed typo. * Reset settings. * Added special windows path handling. * Added unit test for HTTPClient. * Added unit test for BasicTransferAdapter. * Moved into util package. * Test if LFS endpoint is allowed. * Added support for git:// * Just use a static placeholder as the displayed url may be invalid. * Reverted to original code. * Added "Advanced Settings". * Updated wording. * Added discovery info link. * Implemented suggestion. * Fixed missing format parameter. * Added Pointer.IsValid(). * Always remove model on error. * Added suggestions. * Use channel instead of array. * Update routers/repo/migrate.go * fmt Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
		@@ -16,6 +16,7 @@ import (
 | 
			
		||||
	"code.gitea.io/gitea/modules/cache"
 | 
			
		||||
	"code.gitea.io/gitea/modules/git"
 | 
			
		||||
	"code.gitea.io/gitea/modules/graceful"
 | 
			
		||||
	"code.gitea.io/gitea/modules/lfs"
 | 
			
		||||
	"code.gitea.io/gitea/modules/log"
 | 
			
		||||
	"code.gitea.io/gitea/modules/notification"
 | 
			
		||||
	repo_module "code.gitea.io/gitea/modules/repository"
 | 
			
		||||
@@ -206,7 +207,7 @@ func parseRemoteUpdateOutput(output string) []*mirrorSyncResult {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// runSync returns true if sync finished without error.
 | 
			
		||||
func runSync(m *models.Mirror) ([]*mirrorSyncResult, bool) {
 | 
			
		||||
func runSync(ctx context.Context, m *models.Mirror) ([]*mirrorSyncResult, bool) {
 | 
			
		||||
	repoPath := m.Repo.RepoPath()
 | 
			
		||||
	wikiPath := m.Repo.WikiPath()
 | 
			
		||||
	timeout := time.Duration(setting.Git.Timeout.Mirror) * time.Second
 | 
			
		||||
@@ -253,13 +254,21 @@ func runSync(m *models.Mirror) ([]*mirrorSyncResult, bool) {
 | 
			
		||||
		log.Error("OpenRepository: %v", err)
 | 
			
		||||
		return nil, false
 | 
			
		||||
	}
 | 
			
		||||
	defer gitRepo.Close()
 | 
			
		||||
 | 
			
		||||
	log.Trace("SyncMirrors [repo: %-v]: syncing releases with tags...", m.Repo)
 | 
			
		||||
	if err = repo_module.SyncReleasesWithTags(m.Repo, gitRepo); err != nil {
 | 
			
		||||
		gitRepo.Close()
 | 
			
		||||
		log.Error("Failed to synchronize tags to releases for repository: %v", err)
 | 
			
		||||
	}
 | 
			
		||||
	gitRepo.Close()
 | 
			
		||||
 | 
			
		||||
	if m.LFS && setting.LFS.StartServer {
 | 
			
		||||
		log.Trace("SyncMirrors [repo: %-v]: syncing LFS objects...", m.Repo)
 | 
			
		||||
		readAddress(m)
 | 
			
		||||
		ep := lfs.DetermineEndpoint(m.Address, m.LFSEndpoint)
 | 
			
		||||
		if err = repo_module.StoreMissingLfsObjectsInRepository(ctx, m.Repo, gitRepo, ep); err != nil {
 | 
			
		||||
			log.Error("Failed to synchronize LFS objects for repository: %v", err)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	log.Trace("SyncMirrors [repo: %-v]: updating size of repository", m.Repo)
 | 
			
		||||
	if err := m.Repo.UpdateSize(models.DefaultDBContext()); err != nil {
 | 
			
		||||
@@ -378,12 +387,12 @@ func SyncMirrors(ctx context.Context) {
 | 
			
		||||
			mirrorQueue.Close()
 | 
			
		||||
			return
 | 
			
		||||
		case repoID := <-mirrorQueue.Queue():
 | 
			
		||||
			syncMirror(repoID)
 | 
			
		||||
			syncMirror(ctx, repoID)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func syncMirror(repoID string) {
 | 
			
		||||
func syncMirror(ctx context.Context, repoID string) {
 | 
			
		||||
	log.Trace("SyncMirrors [repo_id: %v]", repoID)
 | 
			
		||||
	defer func() {
 | 
			
		||||
		err := recover()
 | 
			
		||||
@@ -403,7 +412,7 @@ func syncMirror(repoID string) {
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	log.Trace("SyncMirrors [repo: %-v]: Running Sync", m.Repo)
 | 
			
		||||
	results, ok := runSync(m)
 | 
			
		||||
	results, ok := runSync(ctx, m)
 | 
			
		||||
	if !ok {
 | 
			
		||||
		return
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
@@ -48,7 +48,9 @@ func TestRelease_MirrorDelete(t *testing.T) {
 | 
			
		||||
	})
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	mirror, err := repository.MigrateRepositoryGitData(context.Background(), user, mirrorRepo, opts)
 | 
			
		||||
	ctx := context.Background()
 | 
			
		||||
 | 
			
		||||
	mirror, err := repository.MigrateRepositoryGitData(ctx, user, mirrorRepo, opts)
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	gitRepo, err := git.OpenRepository(repoPath)
 | 
			
		||||
@@ -74,7 +76,7 @@ func TestRelease_MirrorDelete(t *testing.T) {
 | 
			
		||||
	err = mirror.GetMirror()
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
 | 
			
		||||
	_, ok := runSync(mirror.Mirror)
 | 
			
		||||
	_, ok := runSync(ctx, mirror.Mirror)
 | 
			
		||||
	assert.True(t, ok)
 | 
			
		||||
 | 
			
		||||
	count, err := models.GetReleaseCountByRepoID(mirror.ID, findOptions)
 | 
			
		||||
@@ -85,7 +87,7 @@ func TestRelease_MirrorDelete(t *testing.T) {
 | 
			
		||||
	assert.NoError(t, err)
 | 
			
		||||
	assert.NoError(t, release_service.DeleteReleaseByID(release.ID, user, true))
 | 
			
		||||
 | 
			
		||||
	_, ok = runSync(mirror.Mirror)
 | 
			
		||||
	_, ok = runSync(ctx, mirror.Mirror)
 | 
			
		||||
	assert.True(t, ok)
 | 
			
		||||
 | 
			
		||||
	count, err = models.GetReleaseCountByRepoID(mirror.ID, findOptions)
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user