mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Refactor the setting to make unit test easier (#22405)
Some bugs caused by less unit tests in fundamental packages. This PR refactor `setting` package so that create a unit test will be easier than before. - All `LoadFromXXX` files has been splited as two functions, one is `InitProviderFromXXX` and `LoadCommonSettings`. The first functions will only include the code to create or new a ini file. The second function will load common settings. - It also renames all functions in setting from `newXXXService` to `loadXXXSetting` or `loadXXXFrom` to make the function name less confusing. - Move `XORMLog` to `SQLLog` because it's a better name for that. Maybe we should finally move these `loadXXXSetting` into the `XXXInit` function? Any idea? --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
		@@ -19,11 +19,11 @@ var (
 | 
			
		||||
	}
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
func newActions() {
 | 
			
		||||
	sec := Cfg.Section("actions")
 | 
			
		||||
func loadActionsFrom(rootCfg ConfigProvider) {
 | 
			
		||||
	sec := rootCfg.Section("actions")
 | 
			
		||||
	if err := sec.MapTo(&Actions); err != nil {
 | 
			
		||||
		log.Fatal("Failed to map Actions settings: %v", err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	Actions.Storage = getStorage("actions_log", "", nil)
 | 
			
		||||
	Actions.Storage = getStorage(rootCfg, "actions_log", "", nil)
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user