mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability - nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length. - unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions - wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements. - notlintlint - Reports ill-formed or insufficient nolint directives - stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
This commit is contained in:
		@@ -74,7 +74,7 @@ func unmarshalAs(bs []byte, exemplar interface{}) (data Data, err error) {
 | 
			
		||||
	} else {
 | 
			
		||||
		err = json.Unmarshal(bs, &data)
 | 
			
		||||
	}
 | 
			
		||||
	return
 | 
			
		||||
	return data, err
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// assignableTo will check if provided data is assignable to the same type as the exemplar
 | 
			
		||||
 
 | 
			
		||||
@@ -73,7 +73,7 @@ func NewByteFIFOQueue(typ Type, byteFIFO ByteFIFO, handle HandlerFunc, cfg, exem
 | 
			
		||||
				failed = append(failed, fail)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
		return
 | 
			
		||||
		return failed
 | 
			
		||||
	}, config.WorkerPoolConfiguration)
 | 
			
		||||
 | 
			
		||||
	return q, nil
 | 
			
		||||
@@ -401,7 +401,7 @@ func NewByteFIFOUniqueQueue(typ Type, byteFIFO UniqueByteFIFO, handle HandlerFun
 | 
			
		||||
				failed = append(failed, fail)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
		return
 | 
			
		||||
		return failed
 | 
			
		||||
	}, config.WorkerPoolConfiguration)
 | 
			
		||||
 | 
			
		||||
	return q, nil
 | 
			
		||||
 
 | 
			
		||||
@@ -62,7 +62,7 @@ func NewPersistableChannelQueue(handle HandlerFunc, cfg, exemplar interface{}) (
 | 
			
		||||
				failed = append(failed, fail)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
		return
 | 
			
		||||
		return failed
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	channelQueue, err := NewChannelQueue(wrappedHandle, ChannelQueueConfiguration{
 | 
			
		||||
 
 | 
			
		||||
@@ -62,7 +62,7 @@ func NewPersistableChannelUniqueQueue(handle HandlerFunc, cfg, exemplar interfac
 | 
			
		||||
				failed = append(failed, fail)
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
		return
 | 
			
		||||
		return failed
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	channelUniqueQueue, err := NewChannelUniqueQueue(wrappedHandle, ChannelUniqueQueueConfiguration{
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user