mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Create a branch directly from commit on the create branch API (#22956)
#### Added - API: Create a branch directly from commit on the create branch API - Added `old_ref_name` parameter to allow creating a new branch from a specific commit, tag, or branch. - Deprecated `old_branch_name` parameter in favor of the new `old_ref_name` parameter. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
		@@ -173,11 +173,35 @@ func CreateBranch(ctx *context.APIContext) {
 | 
			
		||||
		return
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if len(opt.OldBranchName) == 0 {
 | 
			
		||||
		opt.OldBranchName = ctx.Repo.Repository.DefaultBranch
 | 
			
		||||
	var oldCommit *git.Commit
 | 
			
		||||
	var err error
 | 
			
		||||
 | 
			
		||||
	if len(opt.OldRefName) > 0 {
 | 
			
		||||
		oldCommit, err = ctx.Repo.GitRepo.GetCommit(opt.OldRefName)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			ctx.Error(http.StatusInternalServerError, "GetCommit", err)
 | 
			
		||||
			return
 | 
			
		||||
		}
 | 
			
		||||
	} else if len(opt.OldBranchName) > 0 { //nolint
 | 
			
		||||
		if ctx.Repo.GitRepo.IsBranchExist(opt.OldBranchName) { //nolint
 | 
			
		||||
			oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(opt.OldBranchName) //nolint
 | 
			
		||||
			if err != nil {
 | 
			
		||||
				ctx.Error(http.StatusInternalServerError, "GetBranchCommit", err)
 | 
			
		||||
				return
 | 
			
		||||
			}
 | 
			
		||||
		} else {
 | 
			
		||||
			ctx.Error(http.StatusNotFound, "", "The old branch does not exist")
 | 
			
		||||
			return
 | 
			
		||||
		}
 | 
			
		||||
	} else {
 | 
			
		||||
		oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			ctx.Error(http.StatusInternalServerError, "GetBranchCommit", err)
 | 
			
		||||
			return
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	err := repo_service.CreateNewBranch(ctx, ctx.Doer, ctx.Repo.Repository, opt.OldBranchName, opt.BranchName)
 | 
			
		||||
	err = repo_service.CreateNewBranchFromCommit(ctx, ctx.Doer, ctx.Repo.Repository, oldCommit.ID.String(), opt.BranchName)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		if models.IsErrBranchDoesNotExist(err) {
 | 
			
		||||
			ctx.Error(http.StatusNotFound, "", "The old branch does not exist")
 | 
			
		||||
@@ -189,7 +213,7 @@ func CreateBranch(ctx *context.APIContext) {
 | 
			
		||||
		} else if models.IsErrBranchNameConflict(err) {
 | 
			
		||||
			ctx.Error(http.StatusConflict, "", "The branch with the same name already exists.")
 | 
			
		||||
		} else {
 | 
			
		||||
			ctx.Error(http.StatusInternalServerError, "CreateRepoBranch", err)
 | 
			
		||||
			ctx.Error(http.StatusInternalServerError, "CreateNewBranchFromCommit", err)
 | 
			
		||||
		}
 | 
			
		||||
		return
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user