mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Support scoped access tokens (#20908)
This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
This commit is contained in:
		@@ -7,6 +7,7 @@ import (
 | 
			
		||||
	"net/http"
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	auth_model "code.gitea.io/gitea/models/auth"
 | 
			
		||||
	api "code.gitea.io/gitea/modules/structs"
 | 
			
		||||
	"code.gitea.io/gitea/tests"
 | 
			
		||||
 | 
			
		||||
@@ -18,7 +19,7 @@ func TestAPIListEmails(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	normalUsername := "user2"
 | 
			
		||||
	session := loginUser(t, normalUsername)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
 | 
			
		||||
 | 
			
		||||
	req := NewRequest(t, "GET", "/api/v1/user/emails?token="+token)
 | 
			
		||||
	resp := MakeRequest(t, req, http.StatusOK)
 | 
			
		||||
@@ -45,7 +46,7 @@ func TestAPIAddEmail(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	normalUsername := "user2"
 | 
			
		||||
	session := loginUser(t, normalUsername)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeUser)
 | 
			
		||||
 | 
			
		||||
	opts := api.CreateEmailOption{
 | 
			
		||||
		Emails: []string{"user101@example.com"},
 | 
			
		||||
@@ -82,7 +83,7 @@ func TestAPIDeleteEmail(t *testing.T) {
 | 
			
		||||
 | 
			
		||||
	normalUsername := "user2"
 | 
			
		||||
	session := loginUser(t, normalUsername)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session)
 | 
			
		||||
	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeUser)
 | 
			
		||||
 | 
			
		||||
	opts := api.DeleteEmailOption{
 | 
			
		||||
		Emails: []string{"user2-3@example.com"},
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user