mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634)
This PR replaces all string refName as a type `git.RefName` to make the code more maintainable. Fix #15367 Replaces #23070 It also fixed a bug that tags are not sync because `git remote --prune origin` will not remove local tags if remote removed. We in fact should use `git fetch --prune --tags origin` but not `git remote update origin` to do the sync. Some answer from ChatGPT as ref. > If the git fetch --prune --tags command is not working as expected, there could be a few reasons why. Here are a few things to check: > >Make sure that you have the latest version of Git installed on your system. You can check the version by running git --version in your terminal. If you have an outdated version, try updating Git and see if that resolves the issue. > >Check that your Git repository is properly configured to track the remote repository's tags. You can check this by running git config --get-all remote.origin.fetch and verifying that it includes +refs/tags/*:refs/tags/*. If it does not, you can add it by running git config --add remote.origin.fetch "+refs/tags/*:refs/tags/*". > >Verify that the tags you are trying to prune actually exist on the remote repository. You can do this by running git ls-remote --tags origin to list all the tags on the remote repository. > >Check if any local tags have been created that match the names of tags on the remote repository. If so, these local tags may be preventing the git fetch --prune --tags command from working properly. You can delete local tags using the git tag -d command. --------- Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
		@@ -10,6 +10,7 @@ import (
 | 
			
		||||
	"strconv"
 | 
			
		||||
	"time"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/modules/git"
 | 
			
		||||
	"code.gitea.io/gitea/modules/setting"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
@@ -44,7 +45,7 @@ func (g GitPushOptions) Bool(key string, def bool) bool {
 | 
			
		||||
type HookOptions struct {
 | 
			
		||||
	OldCommitIDs                    []string
 | 
			
		||||
	NewCommitIDs                    []string
 | 
			
		||||
	RefFullNames                    []string
 | 
			
		||||
	RefFullNames                    []git.RefName
 | 
			
		||||
	UserID                          int64
 | 
			
		||||
	UserName                        string
 | 
			
		||||
	GitObjectDirectory              string
 | 
			
		||||
@@ -89,7 +90,7 @@ type HookProcReceiveRefResult struct {
 | 
			
		||||
	OldOID       string
 | 
			
		||||
	NewOID       string
 | 
			
		||||
	Ref          string
 | 
			
		||||
	OriginalRef  string
 | 
			
		||||
	OriginalRef  git.RefName
 | 
			
		||||
	IsForcePush  bool
 | 
			
		||||
	IsNotMatched bool
 | 
			
		||||
	Err          string
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user