Giteabot
5b670d83e1
Fix panic in storageHandler ( #27446 ) ( #27479 )
...
Backport #27446 by @sryze
storageHandler() is written as a middleware but is used as an endpoint
handler, and thus `next` is actually `nil`, which causes a null pointer
dereference when a request URL does not match the pattern (where it
calls `next.ServerHTTP()`).
Example CURL command to trigger the panic:
```
curl -I "http://yourhost/gitea//avatars/a "
```
Fixes #27409
---
Note: the diff looks big but it's actually a small change - all I did
was to remove the outer closure (and one level of indentation) ~and
removed the HTTP method and pattern checks as they seem redundant
because go-chi already does those checks~. You might want to check "Hide
whitespace" when reviewing it.
Alternative solution (a bit simpler): append `, misc.DummyOK` to the
route declarations that utilize `storageHandler()` - this makes it
return an empty response when the URL is invalid. I've tested this one
and it works too. Or maybe it would be better to return a 400 error in
that case (?)
Co-authored-by: Sergey Zolotarev <sryze@outlook.com >
2023-10-06 16:51:26 +02:00
delvh
9207331f4d
Revert #27426 ( #27474 )
...
Apparently, we didn't backport one of the refactoring PRs which caused
the fixup we backported to fail.
Fixes: https://github.com/go-gitea/gitea/issues/27473
2023-10-06 20:47:45 +08:00
Giteabot
44aca6a65a
Don't let API add 2 exclusive labels from same scope ( #27433 ) ( #27460 )
...
Backport #27433 by @JakobDev
Fixes #27380
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-10-06 05:06:31 +08:00
Giteabot
aaf35ee49c
Refactor system setting ( #27000 ) ( #27452 )
...
Backport #27000 by @wxiaoguang
This PR reduces the complexity of the system setting system.
It only needs one line to introduce a new option, and the option can be
used anywhere out-of-box.
It is still high-performant (and more performant) because the config
values are cached in the config system.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-10-05 10:37:59 +00:00
Giteabot
a9d547f55b
When comparing with an non-exist repository, return 404 but 500 ( #27437 ) ( #27442 )
...
Backport #27437 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-10-04 14:41:57 +00:00
Giteabot
51001d9ffe
Fix pr template ( #27436 ) ( #27440 )
...
Backport #27436 by @lunny
Fix #27431
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-10-04 12:56:02 +00:00
Giteabot
1ff6b7783c
Fix missing ctx in new_form.tmpl ( #27434 ) ( #27438 )
...
Backport #27434 by @CaiCandong
Fix #27432
Regression of #27265
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com >
2023-10-04 12:12:06 +00:00
Giteabot
99e2071eeb
Fix yet another ctx template bug ( #27417 ) ( #27426 )
...
Backport #27417 by @delvh
Fixes #27416
Co-authored-by: delvh <dev.lh@web.de >
2023-10-04 07:52:57 +00:00
Giteabot
1dd84ec3a1
Use flex-container for repo and org settings ( #27418 ) ( #27430 )
...
Backport #27418 by @silverwind
Same as https://github.com/go-gitea/gitea/pull/26046 but for repo and
org settings pages, reducing the margins between the boxes:
<img width="1247" alt="Screenshot 2023-10-03 at 23 25 19"
src="https://github.com/go-gitea/gitea/assets/115237/4e68ad5e-5fdc-4466-aefb-ec71bf411d45 ">
<img width="1255" alt="Screenshot 2023-10-03 at 23 27 12"
src="https://github.com/go-gitea/gitea/assets/115237/9068369b-a75d-401e-8b8d-3bd4bbe097dc ">
Co-authored-by: silverwind <me@silverwind.io >
2023-10-04 07:20:43 +00:00
Giteabot
290440e1ee
Add Index to action.user_id ( #27403 ) ( #27425 )
...
Backport #27403 by @JakobDev
Another Column that needs a Index. Found at
https://codeberg.org/forgejo/discussions/issues/61#issuecomment-1258744 .
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-10-04 08:53:00 +02:00
Lunny Xiao
881a844c9d
Add 1.20.5 changelog ( #27404 ) ( #27412 )
...
frontend #27404
2023-10-03 22:21:19 +08:00
Giteabot
d5da0e622c
Don't use subselect in DeleteIssuesByRepoID ( #27332 ) ( #27408 )
...
Backport #27332 by @JakobDev
Part of https://codeberg.org/forgejo/discussions/issues/61
This is workaround for a bug in MariaDB
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-10-03 17:59:45 +08:00
Giteabot
8c6464e39b
Add support for HEAD ref in /src/branch and /src/commit routes ( #27384 ) ( #27407 )
...
Backport #27384 by @rbhz
Add support for HEAD in paths:
```
/src/branch/HEAD/README.md
/src/commit/HEAD/README.md
```
Closes #26920
Co-authored-by: Kirill Sorokin <48334247+rbhz@users.noreply.github.com >
2023-10-03 08:13:49 +00:00
Giteabot
4f02b4a7b9
Make Actions tasks/jobs timeouts configurable by the user ( #27400 ) ( #27402 )
...
Backport #27400 by @fantognazza
With this PR we added the possibility to configure the Actions timeouts
values for killing tasks/jobs.
Particularly this enhancement is closely related to the `act_runner`
configuration reported below:
```
# The timeout for a job to be finished.
# Please note that the Gitea instance also has a timeout (3h by default) for the job.
# So the job could be stopped by the Gitea instance if it's timeout is shorter than this.
timeout: 3h
```
---
Setting the corresponding key in the INI configuration file, it is
possible to let jobs run for more than 3 hours.
Signed-off-by: Francesco Antognazza <francesco.antognazza@gmail.com >
2023-10-03 10:26:35 +08:00
Giteabot
7dc5ab2e95
Fix git 2.11 error when checking IsEmpty ( #27393 ) ( #27397 )
...
Backport #27393 by @wxiaoguang
Fix #27389
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-10-02 22:36:18 +02:00
Giteabot
28d970e4a6
Hide archived labels when filtering by labels on the issue list ( #27115 ) ( #27381 )
...
Backport #27115 by @puni9869
Followup https://github.com/go-gitea/gitea/pull/26820
## Archived labels UI for issue filter and issue filter actions for
issues/pull request pages.
Changed:
* Enhanced the Issue filter and Issue filter actions UI page to
seamlessly incorporate a list of archived labels.
* Pagination functionality is same as before. If archived label checkbox
is checked then we are adding a query string`archived=true` in the url
to save the state of page.
* Issue filter actions menu is separated into different template.
* Adding the archived flag in issue url labels.
* Pull Request page is also work the same.
Outsourced:
* Defer the implementation of specialized handling for archived labels
to upcoming pull requests. This step will be undertaken subsequent to
the successful merge of this pull request.
Screenshots
### Issue page
<img width="1360" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/d7efb2ef-5b2b-449d-83f0-d430a32ec432 ">
### Issue page with label filter on archived label checkbox when not
checked --> No archived label is there in list
<img width="1249" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/ceea68ef-91f2-4693-910f-2e25e236bfc9 ">
### Issue page with label filter on archived label checkbox when checked
--> Show archived label in the list.
<img width="710" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/2414d26b-2079-4c3c-bd9e-f2f5411bcabf ">
### Issue page with label filter on issue action menu on archived label
checkbox when checked --> Show archived label in the list.
<img width="409" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/259cac87-3e21-4778-99a2-a6a0b8c81178 ">
### Applied the archived=true in Issue labels when archived checkbox is
checked.
<img width="984" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/657ce3db-c0ae-402e-b12d-3b580d3c2ed0 ">
---
Part of https://github.com/go-gitea/gitea/issues/25237
Signed-off-by: puni9869 <punitinani1@hotmail.com >
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-10-01 22:56:48 -04:00
Giteabot
4e824a735e
Allow get release download files and lfs files with oauth2 token format ( #26430 ) ( #27379 )
...
Backport #26430 by @lunny
Fix #26165
Fix #25257
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-10-01 19:54:11 +08:00
Giteabot
eea79ce586
highlight user details link ( #26998 ) ( #27376 )
...
Backport #26998 by @denyskon
This PR adds a separated column in the users table for operations. The
username link now redirects back to user page.
Resolves
https://github.com/go-gitea/gitea/pull/26713#pullrequestreview-1603001285
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Denys Konovalov <kontakt@denyskon.de >
Co-authored-by: silverwind <me@silverwind.io >
2023-10-01 10:23:42 +00:00
Giteabot
e9340ce9bc
Fix missing ctx for GetRepoLink in dashboard ( #27372 ) ( #27375 )
...
Backport #27372 by @CaiCandong
As title
Fix #27369
Regression of #27265
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com >
2023-10-01 09:54:58 +00:00
Giteabot
de387102b4
Introduce fixes and more rigorous tests for 'Show on a map' feature ( #26803 ) ( #27365 )
...
Backport #26803 by @n0toose
This change introduces some fixes for my original PR
(https://github.com/go-gitea/gitea/pull/26214 ) and introduces some
additional tests so that such a regression does not happen again in the
future.
Co-authored-by: Panagiotis "Ivory" Vasilopoulos <git@n0toose.net >
2023-09-30 15:58:35 +00:00
Giteabot
79c17d8b6a
Absolute positioned checkboxes overlay floated elements ( #26870 ) ( #27366 )
...
Backport #26870 by @rafh
Currently, checkboxes are positioned as absolute. This positioning
causes the input to overlay an element that has been floated within the
editor. Floated elements are useful if you want your text to wrap around
this element. This PR fixes the overlaying of checkboxes by removing the
absolute positioning, updating the `ul` padding, and
displaying`.task-list-item` `flex` to ensure inputs and the associated
label are on the same line.
Screenshots:
Before:
<img width="762" alt="Screenshot 2023-09-01 at 3 40 59 PM"
src="https://github.com/go-gitea/gitea/assets/6152817/570247c7-7f5c-4697-bfc9-ad4655e37991 ">
After:
<img width="762" alt="Screenshot 2023-09-01 at 3 42 20 PM"
src="https://github.com/go-gitea/gitea/assets/6152817/db53df45-1294-4eee-84c0-b21ac4fdf805 ">
Co-authored-by: Rafael Heard <rafael.heard@gmail.com >
Co-authored-by: rafh <rafaelheard@gmail.com >
2023-09-30 17:10:48 +02:00
Giteabot
006c15fb5f
Fix template bug ( #27362 ) ( #27364 )
...
Backport #27362 by @lunny
Fix #27361
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-30 09:30:30 +00:00
Giteabot
0c4f97c112
Fix repo count in org action settings ( #27245 ) ( #27353 )
...
Backport #27245 by @yp05327
Only in org action settings, repo count is missing
Before:
In other setting page:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2023-09-29 20:00:24 +02:00
Giteabot
f9395eaa08
Add protected branch name description ( #27257 ) ( #27351 )
...
Backport #27257 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-09-29 16:38:11 +02:00
Giteabot
f13a294b47
More db.DefaultContext refactor ( #27265 ) ( #27347 )
...
Backport #27265 by @JakobDev
Part of #27065
This PR touches functions used in templates. As templates are not static
typed, errors are harder to find, but I hope I catch it all. I think
some tests from other persons do not hurt.
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-09-29 13:35:01 +00:00
Giteabot
84ee02faa7
Improve tree not found page ( #26570 ) ( #27346 )
...
Backport #26570 by @yp05327
Before:
After:
In Github:
https://github.com/yp05327/test/blob/main/test.drawio
Updated:
UI changed
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-29 18:35:11 +08:00
Giteabot
f77b4cb4a2
Add logs for data broken of comment review ( #27326 ) ( #27345 )
...
Backport #27326 by @lunny
Fix #27306
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-29 13:31:13 +08:00
Giteabot
7ea7f2b37f
Add Index to comment.dependent_issue_id ( #27325 ) ( #27340 )
...
Backport #27325 by @JakobDev
This Column is missing index. It is used by
[issue_service.deleteIssue](7ea2a910ce/services/issue/issue.go (L300)jakobdev@gmx.de >
2023-09-29 02:00:14 +00:00
Giteabot
c61b9c5f3c
Fix the approval count of PR when there is no protection branch rule ( #27272 ) ( #27343 )
...
Backport #27272 by @lng2020
As title
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-09-29 09:31:35 +08:00
Giteabot
e719bf8ead
Fix review UI ( #27322 ) ( #27331 )
...
Backport #27322 by @wxiaoguang
Close #26730
1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-09-28 13:27:13 +00:00
Giteabot
9903b8d7ec
Fix Bug in Issue Config when only contact links are set ( #26521 ) ( #27334 )
...
Backport #26521 by @JakobDev
Blank Issues should be enabled if they are not explicit disabled through
the `blank_issues_enabled` field of the Issue Config. The Implementation
has currently a Bug: If you create a Issue Config file with only
`contact_links` and without a `blank_issues_enabled` field,
`blank_issues_enabled` is set to false by default.
The fix is only one line, but I decided to also improve the tests to
make sure there are no other problems with the Implementation.
This is a bugfix, so it should be backported to 1.20.
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-09-28 20:55:45 +08:00
Giteabot
77ccd215e2
Fix divider in subscription page ( #27298 ) ( #27301 )
...
Backport #27298 by @yp05327
divider should always display in subscription page.
Before:
After:
(no changes when there's no subscriptions)
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.com >
2023-09-28 10:37:33 +00:00
Giteabot
71d1bfea7f
Improve issue history dialog and make poster can delete their own history ( #27323 ) ( #27327 )
...
Backport #27323 by @wxiaoguang
Fix #27313 (see the comment)
And some UI improvements:
### Before
### After
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-09-28 09:46:46 +00:00
Giteabot
b00489886d
Improve branch list UI ( #27319 ) ( #27324 )
...
Backport #27319 by @wxiaoguang
1. Put the `"octicon-shield-lock"` into the flex container, then it
doesn't need a separate flex box
2. Remove some unnecessary `gt-df` helpers
3. Make `btn` button has the same flex behavior as `ui button`
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-09-28 06:14:34 +00:00
Giteabot
9b698362a3
Redefine the meaning of column is_active to make Actions Registration Token generation easier ( #27143 ) ( #27304 )
...
Backport #27143 by @lunny
Partially Fix #25041
This PR redefined the meaning of column `is_active` in table
`action_runner_token`.
Before this PR, `is_active` means whether it has been used by any
runner. If it's true, other runner cannot use it to register again.
In this PR, `is_active` means whether it's validated to be used to
register runner. And if it's true, then it can be used to register
runners until it become false. When creating a new `is_active` register
token, any previous tokens will be set `is_active` to false.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-28 04:15:53 +00:00
Giteabot
1a923c95dd
fix orphan check for deleted branch ( #27310 ) ( #27321 )
...
Backport #27310 by @earl-warren
- Modify the deleted branch orphan check to check for the new table
instead.
- Regression from 6e19484f4dhttps://codeberg.org/forgejo/forgejo/issues/1522
(cherry picked from commit c1d888686fe445e4edecb9d835c5b3893b574b75)
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
2023-09-28 10:52:53 +08:00
Giteabot
a6a79add68
Fix protected branch icon location ( #26576 ) ( #27317 )
...
Backport #26576 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2023-09-27 22:51:01 +00:00
Giteabot
d74fba8175
Use vitest globals ( #27102 ) ( #27311 )
...
Backport #27102 by @silverwind
Enable [globals](https://vitest.dev/config/#globals ) in vitest, reducing
the noise in test files.
Co-authored-by: silverwind <me@silverwind.io >
2023-09-27 16:10:08 +02:00
Giteabot
e4cf9d22a7
bump bleve ( #27300 ) ( #27305 )
...
Backport #27300 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.com >
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-27 07:47:30 +00:00
Giteabot
755369df56
Fix yaml test ( #27297 ) ( #27303 )
...
Backport #27297 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-27 15:05:35 +08:00
Giteabot
42f7c2ad89
Enable production source maps for index.js, fix CSS sourcemaps ( #27291 ) ( #27295 )
...
Backport #27291 by @silverwind
Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
https://github.com/go-gitea/gitea/issues/27213 . This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.
Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.
The chinese docs are machine-translated, please correct accordingly.
Co-authored-by: silverwind <me@silverwind.io >
2023-09-27 04:26:28 +02:00
Giteabot
fee8522052
Fix some animation bugs ( #27287 ) ( #27294 )
...
Backport #27287
Fix #27286
Replace #27279
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-09-27 01:24:25 +00:00
Giteabot
34c440996d
Add missed return to actions view fetch ( #27289 ) ( #27293 )
...
Backport #27289 by @silverwind
Should fix: https://github.com/go-gitea/gitea/issues/27213
@denyskon can you test this? I can not reproduce this error locally.
Co-authored-by: silverwind <me@silverwind.io >
2023-09-27 09:10:21 +08:00
Giteabot
283b19bad5
Fix more yaml lint errors ( #27284 ) ( #27288 )
...
Backport #27284 by @lunny
Fix #27268
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-09-26 19:00:12 +02:00
Giteabot
f0045f4113
Add missing IconHTML size ( #27269 ) ( #27283 )
...
Backport #27269 by @wxiaoguang
Fix #27223
Regression of #27122
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-09-26 15:10:41 +00:00
Giteabot
0abd78e6a8
Fix incorrect change from #27231 ( #27275 ) ( #27282 )
...
Backport #27275 by @delvh
Co-authored-by: delvh <dev.lh@web.de >
2023-09-26 13:39:39 +00:00
Giteabot
fc7d3f7315
Another round of db.DefaultContext refactor ( #27103 ) ( #27262 )
...
Backport #27103 by @JakobDev
Part of #27065
Co-authored-by: JakobDev <jakobdev@gmx.de >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-09-25 19:24:35 +02:00
wxiaoguang
597b04fe2f
Backport ctx locale refactoring manually ( #27231 ) ( #27259 ) ( #27260 )
...
Backport #27231 #27259 manually
---------
Co-authored-by: delvh <dev.lh@web.de >
2023-09-25 13:15:51 +00:00
Giteabot
2774a2afc6
Disable Test Delivery and Replay webhook buttons when webhook is inactive ( #27211 ) ( #27253 )
...
Backport #27211 by @yardenshoham
These buttons are now disabled when the webhook is not active.
The buttons were always enabled before this change.
- Fixes #26824
- Replaces #26814
# Before
# After
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: Yarden Shoham <git@yardenshoham.com >
2023-09-25 10:21:06 +00:00
Giteabot
89b6f20bf8
Fix PushEvent NullPointerException jenkinsci/github-plugin ( #27203 ) ( #27251 )
...
Backport #27203 by @Nabapadma-sarker
Fixes #27202
Co-authored-by: Nabapadma-sarker <nabapadmacse1991@gmail.com >
2023-09-25 08:24:50 +00:00
