zeripath
4f64688902
Truncate long commit message header ( #10301 ) ( #10319 )
...
* Truncate long commit message header
* Fix overflow in view commit table
* Use @media less
* Further improvements
* Fix the commit message on small screens
* adjust width of minimal table
2020-02-18 08:51:39 +01:00
Lunny Xiao
987cd277f6
Fix reply on code review ( #10227 ) ( #10257 )
...
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2020-02-13 11:32:30 +02:00
Lauris BH
80eb50655a
Fix followers and following tabs in profile ( #10202 ) ( #10203 )
2020-02-09 21:00:24 +00:00
guillep2k
b5b44364e3
Allow emoji on review head comments ( #10159 ) ( #10174 )
...
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-02-07 21:39:24 +01:00
Lunny Xiao
049af0d3d0
Fix branch page pull request title and link error ( #10092 ) ( #10097 )
...
* Fix branch page pull request title and link error (#10092 )
2020-02-01 15:14:56 +00:00
6543
b3549bb5ec
[UI] Show pull icon on pull ( #10061 ) ( #10062 )
2020-01-29 20:40:43 +00:00
Lunny Xiao
16dfd9ffbe
Sanitize credentials in mirror form ( #9975 ) ( #9991 )
2020-01-26 08:16:53 +00:00
6543
128cc34344
Fixed repo link in generated comment for cross repository dependency ( #9863 ) ( #9935 )
...
* fixed link to issue in issue comments after adding/removing a dependency, before links assumed the issue was in the same repository. also changed the format of the displayed issue since the issue will not necessarily be in the same repo
* based on pr comments, changed to use HTMLURL instead of piecing together the issue url, and added an if statement around the issue link display as a nil protection
* only showing repo name in dependency comment if the issue is from another repo
Co-authored-by: Brad Albright <32200834+bhalbright@users.noreply.github.com >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-01-22 12:54:40 +02:00
Lunny Xiao
0dced15c1a
Fix wrong hint when status checking is running on pull request view ( #9886 ) ( #9928 )
...
* Fix wrong hint when status checking is running on pull request view
* fix lint
* fix test
* fix test
* fix wrong tmpl
* fix import
* rename function name
2020-01-22 08:06:11 +02:00
Lunny Xiao
f96c1a2c79
Fix wrong permissions check when issues/prs shared operations ( #9885 ) ( #9889 )
...
* Fix wrong permissions check when issues/prs shared operations
* move redirect to the last of the function
* fix swagger
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-20 17:59:33 +02:00
Lunny Xiao
8add1dfacc
Fix issues/pulls dependencies problems ( #9842 ) ( #9864 )
...
* Fix issues/pulls dependencies problems
* fix swagger and api param name
* fix js
2020-01-19 12:56:57 -05:00
David Svantesson
c181070f9e
Repository teams - disable remove button when have access to all ( #9640 )
...
Co-authored-by: zeripath <art27@cantab.net >
2020-01-08 08:36:39 +08:00
zeripath
e5d8e2d10c
Branches not at ref commit ID should not be listed as Merged ( #9614 )
...
Once a branch has been merged if the commit ID no longer equals that of
the pulls ref commit id don't offer to delete the branch on the pull screen
and don't list it as merged on branches.
Fix #9201
When looking at the pull page we should also get the commits from the refs/pulls/x/head
Fix #9158
2020-01-07 17:06:14 +00:00
zeripath
2a1cf5bae9
Add some padding to the shadowed comment box ( #9612 )
...
* Add some padding to the shadowed comment box
* prevent the padding affecting the other comments
2020-01-05 19:25:27 +00:00
David Svantesson
ea707f5a77
Add branch protection option to block merge on requested changes. ( #9592 )
...
* Add branch protection option to block merge on requested changes.
* Add migration step
* Fix check to correct negation
* Apply suggestions from code review
Language improvement.
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com >
* Copyright year.
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-03 19:47:09 +02:00
John Olheiser
b2b10858c6
Don't auto-init SimpleMDE for review textarea ( #9574 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-02 04:02:11 +01:00
Flutterlice
8941f7fc01
Fix for a wrong URL in activity page of repository. (Using config url instead of an actual one) ( #9571 )
2020-01-01 08:54:21 +08:00
zeripath
0c07f1de5b
Provide Default messages for merges ( #9393 )
...
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
2019-12-30 18:34:11 -05:00
6543
261c3a56a2
[Fix] Release attachment should use DownloadURL() not Name ( #9529 )
...
* Handle if two or more attachments have the same name
* previously only the first could be downloaded - now each is downloadable
* dos also take care of #6506 (fix was: #6512 )
* use func DownloadURL() at issue attatchments too
2019-12-28 23:33:13 +00:00
Lunny Xiao
ed67bbe444
Fix repository issues pagination bug when there are more than one label filter ( #9512 )
2019-12-28 14:43:46 +00:00
6543
4ee97465e9
[Fix] AllowedReaction code ( #9518 )
...
* optimize
* CI.restart()
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: zeripath <art27@cantab.net >
2019-12-27 18:43:56 -05:00
6543
f2d03cda96
[API] Extend times API ( #9200 )
...
Extensively extend the times API.
close #8833 ; close #8513 ; close #8559
2019-12-27 20:30:58 +00:00
techknowlogick
590d56dbb3
switch to fomantic-ui ( #9374 )
2019-12-17 16:34:11 -05:00
zeripath
601b0cf4c1
Add description to labels on create issue ( #9392 )
2019-12-17 15:02:17 -05:00
Mario Lubenka
61db834904
Change target branch for pull request ( #6488 )
...
* Adds functionality to change target branch of created pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use const instead of var in JavaScript additions
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Check if branches are equal and if PR already exists before changing target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Make sure to check all commits
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Print error messages for user as error flash message
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Disallow changing target branch of closed or merged pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Resolve conflicts after merge of upstream/master
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Change order of branch select fields
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes duplicate check
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use ctx.Tr for translations
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Recompile JS
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use correct translation namespace
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove redundant if condition
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves most change branch logic into pull service
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Completes comment
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Add Ref to ChangesPayload for logging changed target branches
instead of creating a new struct
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Revert changes to go.mod
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Directly use createComment method
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return 404 if pull request is not found. Move written check up
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove variable declaration
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return client errors on change pull request target errors
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return error in commit.HasPreviousCommit
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds blank line
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Test patch before persisting new target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update patch before testing (not working)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes patch calls when changeing pull request target
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes unneeded check for base name
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves ChangeTargetBranch completely to pull service. Update patch status.
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Set webhook mode after errors were validated
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update PR in one transaction
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Move logic for check if head is equal with branch to pull model
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds missing comment and simplify return
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adjust CreateComment method call
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
2019-12-16 14:20:25 +08:00
zeripath
dc2fe9801f
Make repository management section handle lfs locks ( #8726 )
...
* Make repository maangement section handle lfs locks
* Add check attribute handling and handle locking paths better
* More cleanly check-attributes
* handle error
* Check if file exists in default branch before linking to it.
* fixup
* Properly cleanPath
* Use cleanPath
* Sigh
2019-12-12 21:18:07 +08:00
Oscar Costa
1583c48e3a
Show label list on label set ( #9251 )
...
* Showing the list of labels of template files #7812
* Returning and logging errors when loading labels
* Commenting public method
* Change log level in case of error loading labels.
2019-12-06 21:13:19 -05:00
jaqra
8875586570
Change some label colors ( #9051 )
...
* Change label colors
* Override black basic label background for green theme on label list
2019-12-03 20:39:58 -05:00
David Svantesson
bac4b78e09
Branch protection: Possibility to not use whitelist but allow anyone with write access ( #9055 )
...
* Possibility to not use whitelist but allow anyone with write access
* fix existing test
* rename migration function
* Try to give a better name for migration step
* Clear settings if higher level setting is not set
* Move official reviews to db instead of counting approvals each time
* migration
* fix
* fix migration
* fix migration
* Remove NOT NULL from EnableWhitelist as migration isn't possible
* Fix migration, reviews are connected to issues.
* Fix SQL query issues in GetReviewersByPullID.
* Simplify function GetReviewersByIssueID
* Handle reviewers that has been deleted
* Ensure reviews for test is in a well defined order
* Only clear and set official reviews when it is an approve or reject.
2019-12-03 20:08:56 -05:00
mrsdizzie
bdbdd6608f
Don't link wiki revision to commit ( #9244 )
...
In #7907 a change was made to use the same template for repo and wiki
commit lists. However, there is no code or logic for showing the diff of
a wiki commit so it just produces broken links like:
5e72eeb008
This just removes the link for now until that feature is implemented
2019-12-03 13:15:41 -05:00
John Olheiser
51432ebb9c
Fix context menu overflow & review tag margin ( #9231 )
...
* Fix context menu overflow
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add review tag CSS
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-03 01:03:30 +02:00
6543
668eaf95d5
[Feature] Custom Reactions ( #8886 )
...
* add [ui] Reactions
* move contend check from form to go functions
* use else if
* check if reaction is allowed only on react
(so previous custom reaction can be still removed)
* use $.AllowedReactions in templates
* use ctx.Flash.Error
* use it there too
* add redirection
* back to server error
because a wrong reaction is a template issue ...
* add emoji list link
* add docs entry
* small wording nit
suggestions from @jolheiser - thx
* same reactions as github
* fix PR reactions
* handle error so template JS could check
* Add Integrations Test
* add REACTIONS setting to cheat-sheet doc page
2019-12-01 17:57:24 -05:00
programkode
c9d50bcab5
Correct tooltip msg blocked by dependencies ( #9211 )
2019-11-29 14:05:49 -05:00
John Olheiser
62bcb2b7f1
Add avatar and issue labels to template repositories ( #9149 )
...
* Add avatar and issue labels
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix redundant if-err
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-11-25 13:17:51 +08:00
Lauris BH
95c3dc856a
Fix max length check and limit in multiple repo forms ( #9148 )
...
* Fix input field max length for release, label and milestone forms
* Add max length for isseu and PR title
2019-11-25 01:06:23 +02:00
John Olheiser
e84326aaec
Add git hooks and webhooks to template repositories; move to services ( #8926 )
...
* Add git hooks and webhooks to template options
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update models/repo.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Add tooltip if the user can't edit git hooks
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Close repositories after copying git hooks
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Wording
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Restructure for services
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Return errors
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move GenerateRepository to using a DBContext
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Wrap with models.WithTx
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Remove debug print
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move if-error-delete-repo outside WithTx
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Return nil if no repo generated
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-11-24 12:57:52 -05:00
John Olheiser
eb0359cad4
Context menus for comments ( #9043 )
...
* Add quote replies
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-11-19 20:33:42 +02:00
guillep2k
b15f26b1cf
Close/reopen issues by keywords in titles and comments ( #8866 )
...
* Add close/reopen from comment functionality
* Fix comment
* Rewrite closing/reopening template
* Check xref permissions, move action to services/pull
* Fix RefIsPull field
* Add xref tests
* Fix xref unique filter
* Only highlight keywords for actionable xrefs
* Fix xref neuter filter
* Fix check return status
* Restart CI
2019-11-18 15:13:07 +02:00
Cherrg
1c911aa825
wiki - add 'write' 'preview' buttons to wiki edit like in issues ( #7241 )
...
* Add add 'write' 'preview' buttons to wiki edit like in issues
affects #6975
Signed-off-by: Michael Gnehr <michael@gnehr.de >
* update dark theme
Signed-off-by: Michael Gnehr <michael@gnehr.de >
* fix css lint warnings - missing spaces
Signed-off-by: Michael Gnehr <michael@gnehr.de >
* hide preview button on no fullscreen toolbar
Signed-off-by: Michael Gnehr <michael@gnehr.de >
2019-11-17 14:42:44 -05:00
jaqra
aa178176db
Add first issue comment hashtag ( #9052 )
2019-11-17 16:00:39 +02:00
Vedran
4f9443cf8e
Button tooltip formatting under Branches ( #9034 )
...
* Fixes button tooltip formatting under Branches
* Formatting on download button for default branch
2019-11-16 12:03:07 +00:00
Vedran
97dc314652
Fix broken link to branch from issue list ( #9003 )
...
* Fix broken link to branch from issue list
* Update templates/repo/issue/list.tmpl
Co-Authored-By: mrsdizzie <info@mrsdizzie.com >
* apply @mrsdizzie's review
2019-11-15 11:38:54 +00:00
Benno
149a9df9e8
Expand/Collapse Files and Blob Excerpt while Reviewing/Comparing code ( #8924 )
...
* update #8659 fold/unfold code diffs
* add fold button style
* update #8659 implement expand up/down codes (blob excerpt)
* fix golint errors
* fix expand direction
* remove debug message
* update css style for blob exceprt
* fix typo in comment
* update style sheet with less
* update expect diff (add SectionInfo)
* update #8942 accept suggested change (fix typo)
* close reader and check file type before get tail section
* adjust button position and check file type before insert fold button
* move index js to web_src
* merge index.js with master
* generate index.js
* update js coding style
2019-11-15 10:52:59 +08:00
Lunny Xiao
9bd879bef8
fix bug when pack js ( #8992 )
2019-11-14 19:58:32 +02:00
Lunny Xiao
afe50873a5
Move index.js to web_src and use webpack to pack them ( #8598 )
...
* Move index.js to web_src and use webpack
* Fix initHeatMap
* update eslint and move webpack to devDependencies
* update index.js
* add eslint env node
2019-11-13 15:52:13 +01:00
Antoine GIRARD
cda8de2004
Show repository size in repo home page and settings ( #8940 )
...
* feat: display repository size on repo home and settings
* refactor: move repo size up in setting page
2019-11-13 00:45:19 +00:00
John Olheiser
74a6add4d9
Template Repositories ( #8768 )
...
* Start work on templates
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Continue work
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix IsTemplate vs IsGenerated
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix tabs vs spaces
* Tabs vs Spaces
* Add templates to API & start adding tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix integration tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Remove unused User
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move template tests to existing repos
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Minor re-check updates and cleanup
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* make fmt
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Test cleanup
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix optionalbool
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* make fmt
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Test fixes and icon change
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add new user and repo for tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix tests (finally)
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update meta repo with env variables
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move generation to create page
Combine with repo create template
Modify API search to prioritize owner for repo
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix tests and coverage
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix swagger and JS lint
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix API searching for own private repos
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Change wording
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix repo search test. User had a private repo that didn't show up
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Another search test fix
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Clarify git content
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Feedback updates
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add topics WIP
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Finish adding topics
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update locale
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-11-11 23:15:29 +08:00
mrsdizzie
d9be82bd00
Fix edit content button on migrated issue content ( #8877 )
...
Typo on a closing span tag caused edit button not to work properly on
the original issue content for a migrated issue.
Fixes #8876
2019-11-08 09:01:24 +02:00
mrsdizzie
b747501337
Show due date in dashboard issues list ( #8860 )
...
* Show due date in dashboard issues list
Include due date when vieiwiing all issues on dashboard (matching what
we show for repo issue lists).
Fixes #8859
* Put in same order as repo issue list
* Add suggested changes and also update repo issue list to match
2019-11-07 21:12:23 +01:00
Lauris BH
a91679c9e3
Add additional periods to activity page ( #8829 )
2019-11-05 00:45:48 -05:00