mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	* Add email validity check (#13475) * Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. * API returns 422 error when key with name exists * Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails * Add further tests * Add signup email tests * Add email validity check for linking existing account * Address PR comments * Remove unneeded DB session * Move email check to updateUser Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * skip email validation on empty string (#13627) - move validation into its own function - use a session for UpdateUserSetting * rm TODO for backport Co-authored-by: Chris Shyi <chrisshyi13@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
		
			
				
	
	
		
			166 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			166 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2017 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package integrations
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"net/http"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models"
 | 
						|
	api "code.gitea.io/gitea/modules/structs"
 | 
						|
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
)
 | 
						|
 | 
						|
func TestAPIAdminCreateAndDeleteSSHKey(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	// user1 is an admin user
 | 
						|
	session := loginUser(t, "user1")
 | 
						|
	keyOwner := models.AssertExistsAndLoadBean(t, &models.User{Name: "user2"}).(*models.User)
 | 
						|
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/admin/users/%s/keys?token=%s", keyOwner.Name, token)
 | 
						|
	req := NewRequestWithValues(t, "POST", urlStr, map[string]string{
 | 
						|
		"key":   "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n",
 | 
						|
		"title": "test-key",
 | 
						|
	})
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusCreated)
 | 
						|
 | 
						|
	var newPublicKey api.PublicKey
 | 
						|
	DecodeJSON(t, resp, &newPublicKey)
 | 
						|
	models.AssertExistsAndLoadBean(t, &models.PublicKey{
 | 
						|
		ID:          newPublicKey.ID,
 | 
						|
		Name:        newPublicKey.Title,
 | 
						|
		Content:     newPublicKey.Key,
 | 
						|
		Fingerprint: newPublicKey.Fingerprint,
 | 
						|
		OwnerID:     keyOwner.ID,
 | 
						|
	})
 | 
						|
 | 
						|
	req = NewRequestf(t, "DELETE", "/api/v1/admin/users/%s/keys/%d?token=%s",
 | 
						|
		keyOwner.Name, newPublicKey.ID, token)
 | 
						|
	session.MakeRequest(t, req, http.StatusNoContent)
 | 
						|
	models.AssertNotExistsBean(t, &models.PublicKey{ID: newPublicKey.ID})
 | 
						|
}
 | 
						|
 | 
						|
func TestAPIAdminDeleteMissingSSHKey(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	// user1 is an admin user
 | 
						|
	session := loginUser(t, "user1")
 | 
						|
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
	req := NewRequestf(t, "DELETE", "/api/v1/admin/users/user1/keys/%d?token=%s", models.NonexistentID, token)
 | 
						|
	session.MakeRequest(t, req, http.StatusNotFound)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPIAdminDeleteUnauthorizedKey(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	adminUsername := "user1"
 | 
						|
	normalUsername := "user2"
 | 
						|
	session := loginUser(t, adminUsername)
 | 
						|
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/admin/users/%s/keys?token=%s", adminUsername, token)
 | 
						|
	req := NewRequestWithValues(t, "POST", urlStr, map[string]string{
 | 
						|
		"key":   "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC4cn+iXnA4KvcQYSV88vGn0Yi91vG47t1P7okprVmhNTkipNRIHWr6WdCO4VDr/cvsRkuVJAsLO2enwjGWWueOO6BodiBgyAOZ/5t5nJNMCNuLGT5UIo/RI1b0WRQwxEZTRjt6mFNw6lH14wRd8ulsr9toSWBPMOGWoYs1PDeDL0JuTjL+tr1SZi/EyxCngpYszKdXllJEHyI79KQgeD0Vt3pTrkbNVTOEcCNqZePSVmUH8X8Vhugz3bnE0/iE9Pb5fkWO9c4AnM1FgI/8Bvp27Fw2ShryIXuR6kKvUqhVMTuOSDHwu6A8jLE5Owt3GAYugDpDYuwTVNGrHLXKpPzrGGPE/jPmaLCMZcsdkec95dYeU3zKODEm8UQZFhmJmDeWVJ36nGrGZHL4J5aTTaeFUJmmXDaJYiJ+K2/ioKgXqnXvltu0A9R8/LGy4nrTJRr4JMLuJFoUXvGm1gXQ70w2LSpk6yl71RNC0hCtsBe8BP8IhYCM0EP5jh7eCMQZNvM= nocomment\n",
 | 
						|
		"title": "test-key",
 | 
						|
	})
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusCreated)
 | 
						|
	var newPublicKey api.PublicKey
 | 
						|
	DecodeJSON(t, resp, &newPublicKey)
 | 
						|
 | 
						|
	session = loginUser(t, normalUsername)
 | 
						|
	token = getTokenForLoggedInUser(t, session)
 | 
						|
	req = NewRequestf(t, "DELETE", "/api/v1/admin/users/%s/keys/%d?token=%s",
 | 
						|
		adminUsername, newPublicKey.ID, token)
 | 
						|
	session.MakeRequest(t, req, http.StatusForbidden)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPISudoUser(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	adminUsername := "user1"
 | 
						|
	normalUsername := "user2"
 | 
						|
	session := loginUser(t, adminUsername)
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/user?sudo=%s&token=%s", normalUsername, token)
 | 
						|
	req := NewRequest(t, "GET", urlStr)
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusOK)
 | 
						|
	var user api.User
 | 
						|
	DecodeJSON(t, resp, &user)
 | 
						|
 | 
						|
	assert.Equal(t, normalUsername, user.UserName)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPISudoUserForbidden(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	adminUsername := "user1"
 | 
						|
	normalUsername := "user2"
 | 
						|
 | 
						|
	session := loginUser(t, normalUsername)
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/user?sudo=%s&token=%s", adminUsername, token)
 | 
						|
	req := NewRequest(t, "GET", urlStr)
 | 
						|
	session.MakeRequest(t, req, http.StatusForbidden)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPIListUsers(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	adminUsername := "user1"
 | 
						|
	session := loginUser(t, adminUsername)
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/admin/users?token=%s", token)
 | 
						|
	req := NewRequest(t, "GET", urlStr)
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusOK)
 | 
						|
	var users []api.User
 | 
						|
	DecodeJSON(t, resp, &users)
 | 
						|
 | 
						|
	found := false
 | 
						|
	for _, user := range users {
 | 
						|
		if user.UserName == adminUsername {
 | 
						|
			found = true
 | 
						|
		}
 | 
						|
	}
 | 
						|
	assert.True(t, found)
 | 
						|
	numberOfUsers := models.GetCount(t, &models.User{}, "type = 0")
 | 
						|
	assert.Equal(t, numberOfUsers, len(users))
 | 
						|
}
 | 
						|
 | 
						|
func TestAPIListUsersNotLoggedIn(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	req := NewRequest(t, "GET", "/api/v1/admin/users")
 | 
						|
	MakeRequest(t, req, http.StatusUnauthorized)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPIListUsersNonAdmin(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	nonAdminUsername := "user2"
 | 
						|
	session := loginUser(t, nonAdminUsername)
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
	req := NewRequestf(t, "GET", "/api/v1/admin/users?token=%s", token)
 | 
						|
	session.MakeRequest(t, req, http.StatusForbidden)
 | 
						|
}
 | 
						|
 | 
						|
func TestAPICreateUserInvalidEmail(t *testing.T) {
 | 
						|
	defer prepareTestEnv(t)()
 | 
						|
	adminUsername := "user1"
 | 
						|
	session := loginUser(t, adminUsername)
 | 
						|
	token := getTokenForLoggedInUser(t, session)
 | 
						|
	urlStr := fmt.Sprintf("/api/v1/admin/users?token=%s", token)
 | 
						|
	req := NewRequestWithValues(t, "POST", urlStr, map[string]string{
 | 
						|
		"email":                "invalid_email@domain.com\r\n",
 | 
						|
		"full_name":            "invalid user",
 | 
						|
		"login_name":           "invalidUser",
 | 
						|
		"must_change_password": "true",
 | 
						|
		"password":             "password",
 | 
						|
		"send_notify":          "true",
 | 
						|
		"source_id":            "0",
 | 
						|
		"username":             "invalidUser",
 | 
						|
	})
 | 
						|
	session.MakeRequest(t, req, http.StatusUnprocessableEntity)
 | 
						|
}
 |