mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	Backport #23351 by @sillyguodong
close: #23347
### Reference and Inference
According to Github REST API
[doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference):
1. The `Drone CI` that can create some commit status by
[API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)
is enabled in `go-gitea/gitea`. So I tried to call the API to get a
commit status list of a PR which is commited to upstream
repo(`go-gitea/gitea`). As a result, the API returned a array of commit
status.

2. Then I tried to call the API to get commit status list of the
reference which of the `SHA` is the same as step 1 in the repo which is
forked from `go-gitea/gitea`. But I got a empty array.

So, I believe it that:
1. The commit status is not shared between upstream repo and forked
repo.
2. The coomit status is bound to a repo that performs actions. (Gitea's
logic is the same)
### Cause
During debugging, I found it that commit status are not stored in the DB
as expected.
So, I located the following code:
8cadd51bf2/services/actions/commit_status.go (L18-L26)
When I create a PR, the type of `event` is `pull request`, not `push`.
So the code return function directly.
### Screenshot



### Other 
In this PR, I also fix the problem of missing icon which represents
running in PRs list.


Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
		
	
		
			
				
	
	
		
			124 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			124 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2023 The Gitea Authors. All rights reserved.
 | 
						|
// SPDX-License-Identifier: MIT
 | 
						|
 | 
						|
package actions
 | 
						|
 | 
						|
import (
 | 
						|
	"context"
 | 
						|
	"fmt"
 | 
						|
 | 
						|
	actions_model "code.gitea.io/gitea/models/actions"
 | 
						|
	"code.gitea.io/gitea/models/db"
 | 
						|
	git_model "code.gitea.io/gitea/models/git"
 | 
						|
	user_model "code.gitea.io/gitea/models/user"
 | 
						|
	api "code.gitea.io/gitea/modules/structs"
 | 
						|
	webhook_module "code.gitea.io/gitea/modules/webhook"
 | 
						|
)
 | 
						|
 | 
						|
func CreateCommitStatus(ctx context.Context, job *actions_model.ActionRunJob) error {
 | 
						|
	if err := job.LoadAttributes(ctx); err != nil {
 | 
						|
		return fmt.Errorf("load run: %w", err)
 | 
						|
	}
 | 
						|
 | 
						|
	run := job.Run
 | 
						|
	var (
 | 
						|
		sha       string
 | 
						|
		creatorID int64
 | 
						|
	)
 | 
						|
 | 
						|
	switch run.Event {
 | 
						|
	case webhook_module.HookEventPush:
 | 
						|
		payload, err := run.GetPushEventPayload()
 | 
						|
		if err != nil {
 | 
						|
			return fmt.Errorf("GetPushEventPayload: %w", err)
 | 
						|
		}
 | 
						|
 | 
						|
		// Since the payload comes from json data, we should check if it's broken, or it will cause panic
 | 
						|
		switch {
 | 
						|
		case payload.Repo == nil:
 | 
						|
			return fmt.Errorf("repo is missing in event payload")
 | 
						|
		case payload.Pusher == nil:
 | 
						|
			return fmt.Errorf("pusher is missing in event payload")
 | 
						|
		case payload.HeadCommit == nil:
 | 
						|
			return fmt.Errorf("head commit is missing in event payload")
 | 
						|
		}
 | 
						|
 | 
						|
		sha = payload.HeadCommit.ID
 | 
						|
		creatorID = payload.Pusher.ID
 | 
						|
	case webhook_module.HookEventPullRequest:
 | 
						|
		payload, err := run.GetPullRequestEventPayload()
 | 
						|
		if err != nil {
 | 
						|
			return fmt.Errorf("GetPullRequestEventPayload: %w", err)
 | 
						|
		}
 | 
						|
 | 
						|
		switch {
 | 
						|
		case payload.PullRequest == nil:
 | 
						|
			return fmt.Errorf("pull request is missing in event payload")
 | 
						|
		case payload.PullRequest.Head == nil:
 | 
						|
			return fmt.Errorf("head of pull request is missing in event payload")
 | 
						|
		case payload.PullRequest.Head.Repository == nil:
 | 
						|
			return fmt.Errorf("head repository of pull request is missing in event payload")
 | 
						|
		case payload.PullRequest.Head.Repository.Owner == nil:
 | 
						|
			return fmt.Errorf("owner of head repository of pull request is missing in evnt payload")
 | 
						|
		}
 | 
						|
 | 
						|
		sha = payload.PullRequest.Head.Sha
 | 
						|
		creatorID = payload.PullRequest.Head.Repository.Owner.ID
 | 
						|
	default:
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
 | 
						|
	repo := run.Repo
 | 
						|
	ctxname := job.Name
 | 
						|
	state := toCommitStatus(job.Status)
 | 
						|
	creator, err := user_model.GetUserByID(ctx, creatorID)
 | 
						|
	if err != nil {
 | 
						|
		return fmt.Errorf("GetUserByID: %w", err)
 | 
						|
	}
 | 
						|
	if statuses, _, err := git_model.GetLatestCommitStatus(ctx, repo.ID, sha, db.ListOptions{}); err == nil {
 | 
						|
		for _, v := range statuses {
 | 
						|
			if v.Context == ctxname {
 | 
						|
				if v.State == state {
 | 
						|
					return nil
 | 
						|
				}
 | 
						|
				break
 | 
						|
			}
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		return fmt.Errorf("GetLatestCommitStatus: %w", err)
 | 
						|
	}
 | 
						|
 | 
						|
	if err := git_model.NewCommitStatus(ctx, git_model.NewCommitStatusOptions{
 | 
						|
		Repo:    repo,
 | 
						|
		SHA:     sha,
 | 
						|
		Creator: creator,
 | 
						|
		CommitStatus: &git_model.CommitStatus{
 | 
						|
			SHA:         sha,
 | 
						|
			TargetURL:   run.Link(),
 | 
						|
			Description: "",
 | 
						|
			Context:     ctxname,
 | 
						|
			CreatorID:   creatorID,
 | 
						|
			State:       state,
 | 
						|
		},
 | 
						|
	}); err != nil {
 | 
						|
		return fmt.Errorf("NewCommitStatus: %w", err)
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
func toCommitStatus(status actions_model.Status) api.CommitStatusState {
 | 
						|
	switch status {
 | 
						|
	case actions_model.StatusSuccess:
 | 
						|
		return api.CommitStatusSuccess
 | 
						|
	case actions_model.StatusFailure, actions_model.StatusCancelled, actions_model.StatusSkipped:
 | 
						|
		return api.CommitStatusFailure
 | 
						|
	case actions_model.StatusWaiting, actions_model.StatusBlocked:
 | 
						|
		return api.CommitStatusPending
 | 
						|
	case actions_model.StatusRunning:
 | 
						|
		return api.CommitStatusRunning
 | 
						|
	default:
 | 
						|
		return api.CommitStatusError
 | 
						|
	}
 | 
						|
}
 |