mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 08:30:25 +08:00 
			
		
		
		
	Visually, nothing should have changed. Changes include - Convert most `<a [no href]>` to `<button>` when (re-)viewing files: - `<a [no href]>` are, by HTML definition, not a link and hence cannot be focused - `<a class="ui button">` can now be clicked (again?) using <kbd>Enter</kbd> - Previously, the installed keypress handler on `.ui.button` elements disabled it for links somehow - The `(un)escape file`, the `expand section` and the `expand/collapse file` buttons can now be focused (and subsequently clicked using only the keyboard) - You can now press <kbd>Space</kbd> on a focused `View file` checkbox to mark the file as viewed. - previously, this was impossible as this checkbox listened on the wrong event listener The `add code comment` button has been left inaccessible for now as it requires quite a bit of extra logic so that it is unhidden when it is focused (you can otherwise focus it without seeing it as you are not hovering on the corresponding line). --------- Co-authored-by: silverwind <me@silverwind.io>
		
			
				
	
	
		
			202 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			202 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
import $ from 'jquery';
 | 
						|
import {initCompReactionSelector} from './comp/ReactionSelector.js';
 | 
						|
import {initRepoIssueContentHistory} from './repo-issue-content.js';
 | 
						|
import {initDiffFileTree} from './repo-diff-filetree.js';
 | 
						|
import {validateTextareaNonEmpty} from './comp/ComboMarkdownEditor.js';
 | 
						|
import {initViewedCheckboxListenerFor, countAndUpdateViewedFiles, initExpandAndCollapseFilesButton} from './pull-view-file.js';
 | 
						|
 | 
						|
const {csrfToken} = window.config;
 | 
						|
 | 
						|
function initRepoDiffReviewButton() {
 | 
						|
  const $reviewBox = $('#review-box');
 | 
						|
  const $counter = $reviewBox.find('.review-comments-counter');
 | 
						|
 | 
						|
  $(document).on('click', 'button[name="pending_review"]', (e) => {
 | 
						|
    const $form = $(e.target).closest('form');
 | 
						|
    // Watch for the form's submit event.
 | 
						|
    $form.on('submit', () => {
 | 
						|
      const num = parseInt($counter.attr('data-pending-comment-number')) + 1 || 1;
 | 
						|
      $counter.attr('data-pending-comment-number', num);
 | 
						|
      $counter.text(num);
 | 
						|
      // Force the browser to reflow the DOM. This is to ensure that the browser replay the animation
 | 
						|
      $reviewBox.removeClass('pulse');
 | 
						|
      $reviewBox.width();
 | 
						|
      $reviewBox.addClass('pulse');
 | 
						|
    });
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
function initRepoDiffFileViewToggle() {
 | 
						|
  $('.file-view-toggle').on('click', function () {
 | 
						|
    const $this = $(this);
 | 
						|
    $this.parent().children().removeClass('active');
 | 
						|
    $this.addClass('active');
 | 
						|
 | 
						|
    const $target = $($this.data('toggle-selector'));
 | 
						|
    $target.parent().children().addClass('gt-hidden');
 | 
						|
    $target.removeClass('gt-hidden');
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
function initRepoDiffConversationForm() {
 | 
						|
  $(document).on('submit', '.conversation-holder form', async (e) => {
 | 
						|
    e.preventDefault();
 | 
						|
 | 
						|
    const $form = $(e.target);
 | 
						|
    const $textArea = $form.find('textarea');
 | 
						|
    if (!validateTextareaNonEmpty($textArea)) {
 | 
						|
      return;
 | 
						|
    }
 | 
						|
 | 
						|
    const formData = new FormData($form[0]);
 | 
						|
 | 
						|
    // if the form is submitted by a button, append the button's name and value to the form data
 | 
						|
    const submitter = e.originalEvent?.submitter;
 | 
						|
    const isSubmittedByButton = (submitter?.nodeName === 'BUTTON') || (submitter?.nodeName === 'INPUT' && submitter.type === 'submit');
 | 
						|
    if (isSubmittedByButton && submitter.name) {
 | 
						|
      formData.append(submitter.name, submitter.value);
 | 
						|
    }
 | 
						|
    const formDataString = String(new URLSearchParams(formData));
 | 
						|
    const $newConversationHolder = $(await $.post($form.attr('action'), formDataString));
 | 
						|
    const {path, side, idx} = $newConversationHolder.data();
 | 
						|
 | 
						|
    $form.closest('.conversation-holder').replaceWith($newConversationHolder);
 | 
						|
    if ($form.closest('tr').data('line-type') === 'same') {
 | 
						|
      $(`[data-path="${path}"] .add-code-comment[data-idx="${idx}"]`).addClass('invisible');
 | 
						|
    } else {
 | 
						|
      $(`[data-path="${path}"] .add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible');
 | 
						|
    }
 | 
						|
    $newConversationHolder.find('.dropdown').dropdown();
 | 
						|
    initCompReactionSelector($newConversationHolder);
 | 
						|
  });
 | 
						|
 | 
						|
  $(document).on('click', '.resolve-conversation', async function (e) {
 | 
						|
    e.preventDefault();
 | 
						|
    const comment_id = $(this).data('comment-id');
 | 
						|
    const origin = $(this).data('origin');
 | 
						|
    const action = $(this).data('action');
 | 
						|
    const url = $(this).data('update-url');
 | 
						|
 | 
						|
    const data = await $.post(url, {_csrf: csrfToken, origin, action, comment_id});
 | 
						|
 | 
						|
    if ($(this).closest('.conversation-holder').length) {
 | 
						|
      const conversation = $(data);
 | 
						|
      $(this).closest('.conversation-holder').replaceWith(conversation);
 | 
						|
      conversation.find('.dropdown').dropdown();
 | 
						|
      initCompReactionSelector(conversation);
 | 
						|
    } else {
 | 
						|
      window.location.reload();
 | 
						|
    }
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
export function initRepoDiffConversationNav() {
 | 
						|
  // Previous/Next code review conversation
 | 
						|
  $(document).on('click', '.previous-conversation', (e) => {
 | 
						|
    const $conversation = $(e.currentTarget).closest('.comment-code-cloud');
 | 
						|
    const $conversations = $('.comment-code-cloud:not(.gt-hidden)');
 | 
						|
    const index = $conversations.index($conversation);
 | 
						|
    const previousIndex = index > 0 ? index - 1 : $conversations.length - 1;
 | 
						|
    const $previousConversation = $conversations.eq(previousIndex);
 | 
						|
    const anchor = $previousConversation.find('.comment').first().attr('id');
 | 
						|
    window.location.href = `#${anchor}`;
 | 
						|
  });
 | 
						|
  $(document).on('click', '.next-conversation', (e) => {
 | 
						|
    const $conversation = $(e.currentTarget).closest('.comment-code-cloud');
 | 
						|
    const $conversations = $('.comment-code-cloud:not(.gt-hidden)');
 | 
						|
    const index = $conversations.index($conversation);
 | 
						|
    const nextIndex = index < $conversations.length - 1 ? index + 1 : 0;
 | 
						|
    const $nextConversation = $conversations.eq(nextIndex);
 | 
						|
    const anchor = $nextConversation.find('.comment').first().attr('id');
 | 
						|
    window.location.href = `#${anchor}`;
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
// Will be called when the show more (files) button has been pressed
 | 
						|
function onShowMoreFiles() {
 | 
						|
  initRepoIssueContentHistory();
 | 
						|
  initViewedCheckboxListenerFor();
 | 
						|
  countAndUpdateViewedFiles();
 | 
						|
}
 | 
						|
 | 
						|
export function doLoadMoreFiles(link, diffEnd, callback) {
 | 
						|
  const url = `${link}?skip-to=${diffEnd}&file-only=true`;
 | 
						|
  loadMoreFiles(url, callback);
 | 
						|
}
 | 
						|
 | 
						|
function loadMoreFiles(url, callback) {
 | 
						|
  const $target = $('a#diff-show-more-files');
 | 
						|
  if ($target.hasClass('disabled')) {
 | 
						|
    callback();
 | 
						|
    return;
 | 
						|
  }
 | 
						|
  $target.addClass('disabled');
 | 
						|
  $.ajax({
 | 
						|
    type: 'GET',
 | 
						|
    url,
 | 
						|
  }).done((resp) => {
 | 
						|
    if (!resp) {
 | 
						|
      $target.removeClass('disabled');
 | 
						|
      callback(resp);
 | 
						|
      return;
 | 
						|
    }
 | 
						|
    $('#diff-incomplete').replaceWith($(resp).find('#diff-file-boxes').children());
 | 
						|
    // By simply rerunning the script we add the new data to our existing
 | 
						|
    // pagedata object. this triggers vue and the filetree and filelist will
 | 
						|
    // render the new elements.
 | 
						|
    $('body').append($(resp).find('script#diff-data-script'));
 | 
						|
    onShowMoreFiles();
 | 
						|
    callback(resp);
 | 
						|
  }).fail(() => {
 | 
						|
    $target.removeClass('disabled');
 | 
						|
    callback();
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
function initRepoDiffShowMore() {
 | 
						|
  $(document).on('click', 'a#diff-show-more-files', (e) => {
 | 
						|
    e.preventDefault();
 | 
						|
 | 
						|
    const $target = $(e.target);
 | 
						|
    loadMoreFiles($target.data('href'), () => {});
 | 
						|
  });
 | 
						|
 | 
						|
  $(document).on('click', 'a.diff-load-button', (e) => {
 | 
						|
    e.preventDefault();
 | 
						|
    const $target = $(e.target);
 | 
						|
 | 
						|
    if ($target.hasClass('disabled')) {
 | 
						|
      return;
 | 
						|
    }
 | 
						|
 | 
						|
    $target.addClass('disabled');
 | 
						|
 | 
						|
    const url = $target.data('href');
 | 
						|
    $.ajax({
 | 
						|
      type: 'GET',
 | 
						|
      url,
 | 
						|
    }).done((resp) => {
 | 
						|
      if (!resp) {
 | 
						|
        $target.removeClass('disabled');
 | 
						|
        return;
 | 
						|
      }
 | 
						|
      $target.parent().replaceWith($(resp).find('#diff-file-boxes .diff-file-body .file-body').children());
 | 
						|
      onShowMoreFiles();
 | 
						|
    }).fail(() => {
 | 
						|
      $target.removeClass('disabled');
 | 
						|
    });
 | 
						|
  });
 | 
						|
}
 | 
						|
 | 
						|
export function initRepoDiffView() {
 | 
						|
  initRepoDiffConversationForm();
 | 
						|
  const diffFileList = $('#diff-file-list');
 | 
						|
  if (diffFileList.length === 0) return;
 | 
						|
  initDiffFileTree();
 | 
						|
  initRepoDiffShowMore();
 | 
						|
  initRepoDiffReviewButton();
 | 
						|
  initRepoDiffFileViewToggle();
 | 
						|
  initViewedCheckboxListenerFor();
 | 
						|
  initExpandAndCollapseFilesButton();
 | 
						|
}
 |