mirror of
				https://gitee.com/gitea/gitea
				synced 2025-11-04 16:40:24 +08:00 
			
		
		
		
	`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net>
		
			
				
	
	
		
			343 lines
		
	
	
		
			9.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			343 lines
		
	
	
		
			9.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2021 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package migrations
 | 
						|
 | 
						|
import (
 | 
						|
	"database/sql"
 | 
						|
	"fmt"
 | 
						|
	"os"
 | 
						|
	"path"
 | 
						|
	"path/filepath"
 | 
						|
	"runtime"
 | 
						|
	"testing"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models"
 | 
						|
	"code.gitea.io/gitea/modules/base"
 | 
						|
	"code.gitea.io/gitea/modules/git"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	"code.gitea.io/gitea/modules/timeutil"
 | 
						|
	"code.gitea.io/gitea/modules/util"
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
	"github.com/unknwon/com"
 | 
						|
	"xorm.io/xorm"
 | 
						|
	"xorm.io/xorm/names"
 | 
						|
)
 | 
						|
 | 
						|
func TestMain(m *testing.M) {
 | 
						|
	giteaRoot := base.SetupGiteaRoot()
 | 
						|
	if giteaRoot == "" {
 | 
						|
		fmt.Println("Environment variable $GITEA_ROOT not set")
 | 
						|
		os.Exit(1)
 | 
						|
	}
 | 
						|
	giteaBinary := "gitea"
 | 
						|
	if runtime.GOOS == "windows" {
 | 
						|
		giteaBinary += ".exe"
 | 
						|
	}
 | 
						|
	setting.AppPath = path.Join(giteaRoot, giteaBinary)
 | 
						|
	if _, err := os.Stat(setting.AppPath); err != nil {
 | 
						|
		fmt.Printf("Could not find gitea binary at %s\n", setting.AppPath)
 | 
						|
		os.Exit(1)
 | 
						|
	}
 | 
						|
 | 
						|
	giteaConf := os.Getenv("GITEA_CONF")
 | 
						|
	if giteaConf == "" {
 | 
						|
		giteaConf = path.Join(filepath.Dir(setting.AppPath), "integrations/sqlite.ini")
 | 
						|
		fmt.Printf("Environment variable $GITEA_CONF not set - defaulting to %s\n", giteaConf)
 | 
						|
	}
 | 
						|
 | 
						|
	if !path.IsAbs(giteaConf) {
 | 
						|
		setting.CustomConf = path.Join(giteaRoot, giteaConf)
 | 
						|
	} else {
 | 
						|
		setting.CustomConf = giteaConf
 | 
						|
	}
 | 
						|
 | 
						|
	setting.SetCustomPathAndConf("", "", "")
 | 
						|
	setting.NewContext()
 | 
						|
	git.CheckLFSVersion()
 | 
						|
	setting.InitDBConfig()
 | 
						|
	setting.NewLogServices(true)
 | 
						|
 | 
						|
	exitStatus := m.Run()
 | 
						|
 | 
						|
	if err := removeAllWithRetry(setting.RepoRootPath); err != nil {
 | 
						|
		fmt.Fprintf(os.Stderr, "os.RemoveAll: %v\n", err)
 | 
						|
	}
 | 
						|
	if err := removeAllWithRetry(setting.AppDataPath); err != nil {
 | 
						|
		fmt.Fprintf(os.Stderr, "os.RemoveAll: %v\n", err)
 | 
						|
	}
 | 
						|
	os.Exit(exitStatus)
 | 
						|
}
 | 
						|
 | 
						|
func removeAllWithRetry(dir string) error {
 | 
						|
	var err error
 | 
						|
	for i := 0; i < 20; i++ {
 | 
						|
		err = os.RemoveAll(dir)
 | 
						|
		if err == nil {
 | 
						|
			break
 | 
						|
		}
 | 
						|
		time.Sleep(100 * time.Millisecond)
 | 
						|
	}
 | 
						|
	return err
 | 
						|
}
 | 
						|
 | 
						|
// SetEngine sets the xorm.Engine
 | 
						|
func SetEngine() (*xorm.Engine, error) {
 | 
						|
	x, err := models.GetNewEngine()
 | 
						|
	if err != nil {
 | 
						|
		return x, fmt.Errorf("Failed to connect to database: %v", err)
 | 
						|
	}
 | 
						|
 | 
						|
	x.SetMapper(names.GonicMapper{})
 | 
						|
	// WARNING: for serv command, MUST remove the output to os.stdout,
 | 
						|
	// so use log file to instead print to stdout.
 | 
						|
	x.SetLogger(models.NewXORMLogger(setting.Database.LogSQL))
 | 
						|
	x.ShowSQL(setting.Database.LogSQL)
 | 
						|
	x.SetMaxOpenConns(setting.Database.MaxOpenConns)
 | 
						|
	x.SetMaxIdleConns(setting.Database.MaxIdleConns)
 | 
						|
	x.SetConnMaxLifetime(setting.Database.ConnMaxLifetime)
 | 
						|
	return x, nil
 | 
						|
}
 | 
						|
 | 
						|
func deleteDB() error {
 | 
						|
	switch {
 | 
						|
	case setting.Database.UseSQLite3:
 | 
						|
		if err := util.Remove(setting.Database.Path); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		return os.MkdirAll(path.Dir(setting.Database.Path), os.ModePerm)
 | 
						|
 | 
						|
	case setting.Database.UseMySQL:
 | 
						|
		db, err := sql.Open("mysql", fmt.Sprintf("%s:%s@tcp(%s)/",
 | 
						|
			setting.Database.User, setting.Database.Passwd, setting.Database.Host))
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		defer db.Close()
 | 
						|
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %s", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("CREATE DATABASE IF NOT EXISTS %s", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		return nil
 | 
						|
	case setting.Database.UsePostgreSQL:
 | 
						|
		db, err := sql.Open("postgres", fmt.Sprintf("postgres://%s:%s@%s/?sslmode=%s",
 | 
						|
			setting.Database.User, setting.Database.Passwd, setting.Database.Host, setting.Database.SSLMode))
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		defer db.Close()
 | 
						|
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %s", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("CREATE DATABASE %s", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		db.Close()
 | 
						|
 | 
						|
		// Check if we need to setup a specific schema
 | 
						|
		if len(setting.Database.Schema) != 0 {
 | 
						|
			db, err = sql.Open("postgres", fmt.Sprintf("postgres://%s:%s@%s/%s?sslmode=%s",
 | 
						|
				setting.Database.User, setting.Database.Passwd, setting.Database.Host, setting.Database.Name, setting.Database.SSLMode))
 | 
						|
			if err != nil {
 | 
						|
				return err
 | 
						|
			}
 | 
						|
			defer db.Close()
 | 
						|
 | 
						|
			schrows, err := db.Query(fmt.Sprintf("SELECT 1 FROM information_schema.schemata WHERE schema_name = '%s'", setting.Database.Schema))
 | 
						|
			if err != nil {
 | 
						|
				return err
 | 
						|
			}
 | 
						|
			defer schrows.Close()
 | 
						|
 | 
						|
			if !schrows.Next() {
 | 
						|
				// Create and setup a DB schema
 | 
						|
				_, err = db.Exec(fmt.Sprintf("CREATE SCHEMA %s", setting.Database.Schema))
 | 
						|
				if err != nil {
 | 
						|
					return err
 | 
						|
				}
 | 
						|
			}
 | 
						|
 | 
						|
			// Make the user's default search path the created schema; this will affect new connections
 | 
						|
			_, err = db.Exec(fmt.Sprintf(`ALTER USER "%s" SET search_path = %s`, setting.Database.User, setting.Database.Schema))
 | 
						|
			if err != nil {
 | 
						|
				return err
 | 
						|
			}
 | 
						|
			return nil
 | 
						|
		}
 | 
						|
	case setting.Database.UseMSSQL:
 | 
						|
		host, port := setting.ParseMSSQLHostPort(setting.Database.Host)
 | 
						|
		db, err := sql.Open("mssql", fmt.Sprintf("server=%s; port=%s; database=%s; user id=%s; password=%s;",
 | 
						|
			host, port, "master", setting.Database.User, setting.Database.Passwd))
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		defer db.Close()
 | 
						|
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS [%s]", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		if _, err = db.Exec(fmt.Sprintf("CREATE DATABASE [%s]", setting.Database.Name)); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// prepareTestEnv prepares the test environment and reset the database. The skip parameter should usually be 0.
 | 
						|
// Provide models to be sync'd with the database - in particular any models you expect fixtures to be loaded from.
 | 
						|
//
 | 
						|
// fixtures in `models/migrations/fixtures/<TestName>` will be loaded automatically
 | 
						|
func prepareTestEnv(t *testing.T, skip int, syncModels ...interface{}) (*xorm.Engine, func()) {
 | 
						|
	t.Helper()
 | 
						|
	ourSkip := 2
 | 
						|
	ourSkip += skip
 | 
						|
	deferFn := PrintCurrentTest(t, ourSkip)
 | 
						|
	assert.NoError(t, os.RemoveAll(setting.RepoRootPath))
 | 
						|
 | 
						|
	assert.NoError(t, com.CopyDir(path.Join(filepath.Dir(setting.AppPath), "integrations/gitea-repositories-meta"),
 | 
						|
		setting.RepoRootPath))
 | 
						|
 | 
						|
	if err := deleteDB(); err != nil {
 | 
						|
		t.Errorf("unable to reset database: %v", err)
 | 
						|
		return nil, deferFn
 | 
						|
	}
 | 
						|
 | 
						|
	x, err := SetEngine()
 | 
						|
	assert.NoError(t, err)
 | 
						|
	if x != nil {
 | 
						|
		oldDefer := deferFn
 | 
						|
		deferFn = func() {
 | 
						|
			oldDefer()
 | 
						|
			if err := x.Close(); err != nil {
 | 
						|
				t.Errorf("error during close: %v", err)
 | 
						|
			}
 | 
						|
			if err := deleteDB(); err != nil {
 | 
						|
				t.Errorf("unable to reset database: %v", err)
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
	if err != nil {
 | 
						|
		return x, deferFn
 | 
						|
	}
 | 
						|
 | 
						|
	if len(syncModels) > 0 {
 | 
						|
		if err := x.Sync2(syncModels...); err != nil {
 | 
						|
			t.Errorf("error during sync: %v", err)
 | 
						|
			return x, deferFn
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	fixturesDir := filepath.Join(filepath.Dir(setting.AppPath), "models", "migrations", "fixtures", t.Name())
 | 
						|
 | 
						|
	if _, err := os.Stat(fixturesDir); err == nil {
 | 
						|
		t.Logf("initializing fixtures from: %s", fixturesDir)
 | 
						|
		if err := models.InitFixtures(fixturesDir, x); err != nil {
 | 
						|
			t.Errorf("error whilst initializing fixtures from %s: %v", fixturesDir, err)
 | 
						|
			return x, deferFn
 | 
						|
		}
 | 
						|
		if err := models.LoadFixtures(x); err != nil {
 | 
						|
			t.Errorf("error whilst loading fixtures from %s: %v", fixturesDir, err)
 | 
						|
			return x, deferFn
 | 
						|
		}
 | 
						|
	} else if !os.IsNotExist(err) {
 | 
						|
		t.Errorf("unexpected error whilst checking for existence of fixtures: %v", err)
 | 
						|
	} else {
 | 
						|
		t.Logf("no fixtures found in: %s", fixturesDir)
 | 
						|
	}
 | 
						|
 | 
						|
	return x, deferFn
 | 
						|
}
 | 
						|
 | 
						|
func Test_dropTableColumns(t *testing.T) {
 | 
						|
	x, deferable := prepareTestEnv(t, 0)
 | 
						|
	if x == nil || t.Failed() {
 | 
						|
		defer deferable()
 | 
						|
		return
 | 
						|
	}
 | 
						|
	defer deferable()
 | 
						|
 | 
						|
	type DropTest struct {
 | 
						|
		ID            int64 `xorm:"pk autoincr"`
 | 
						|
		FirstColumn   string
 | 
						|
		ToDropColumn  string `xorm:"unique"`
 | 
						|
		AnotherColumn int64
 | 
						|
		CreatedUnix   timeutil.TimeStamp `xorm:"INDEX created"`
 | 
						|
		UpdatedUnix   timeutil.TimeStamp `xorm:"INDEX updated"`
 | 
						|
	}
 | 
						|
 | 
						|
	columns := []string{
 | 
						|
		"first_column",
 | 
						|
		"to_drop_column",
 | 
						|
		"another_column",
 | 
						|
		"created_unix",
 | 
						|
		"updated_unix",
 | 
						|
	}
 | 
						|
 | 
						|
	for i := range columns {
 | 
						|
		x.SetMapper(names.GonicMapper{})
 | 
						|
		if err := x.Sync2(new(DropTest)); err != nil {
 | 
						|
			t.Errorf("unable to create DropTest table: %v", err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		sess := x.NewSession()
 | 
						|
		if err := sess.Begin(); err != nil {
 | 
						|
			sess.Close()
 | 
						|
			t.Errorf("unable to begin transaction: %v", err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if err := dropTableColumns(sess, "drop_test", columns[i:]...); err != nil {
 | 
						|
			sess.Close()
 | 
						|
			t.Errorf("Unable to drop columns[%d:]: %s from drop_test: %v", i, columns[i:], err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if err := sess.Commit(); err != nil {
 | 
						|
			sess.Close()
 | 
						|
			t.Errorf("unable to commit transaction: %v", err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		sess.Close()
 | 
						|
		if err := x.DropTables(new(DropTest)); err != nil {
 | 
						|
			t.Errorf("unable to drop table: %v", err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		for j := range columns[i+1:] {
 | 
						|
			x.SetMapper(names.GonicMapper{})
 | 
						|
			if err := x.Sync2(new(DropTest)); err != nil {
 | 
						|
				t.Errorf("unable to create DropTest table: %v", err)
 | 
						|
				return
 | 
						|
			}
 | 
						|
			dropcols := append([]string{columns[i]}, columns[j+i+1:]...)
 | 
						|
			sess := x.NewSession()
 | 
						|
			if err := sess.Begin(); err != nil {
 | 
						|
				sess.Close()
 | 
						|
				t.Errorf("unable to begin transaction: %v", err)
 | 
						|
				return
 | 
						|
			}
 | 
						|
			if err := dropTableColumns(sess, "drop_test", dropcols...); err != nil {
 | 
						|
				sess.Close()
 | 
						|
				t.Errorf("Unable to drop columns: %s from drop_test: %v", dropcols, err)
 | 
						|
				return
 | 
						|
			}
 | 
						|
			if err := sess.Commit(); err != nil {
 | 
						|
				sess.Close()
 | 
						|
				t.Errorf("unable to commit transaction: %v", err)
 | 
						|
				return
 | 
						|
			}
 | 
						|
			sess.Close()
 | 
						|
			if err := x.DropTables(new(DropTest)); err != nil {
 | 
						|
				t.Errorf("unable to drop table: %v", err)
 | 
						|
				return
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |