Files
sub2api/backend/internal/service/setting_service_platform_quota_test.go
T

345 lines
13 KiB
Go
Raw Normal View History

//go:build unit
package service
import (
"context"
"testing"
"github.com/Wei-Shaw/sub2api/internal/config"
infraerrors "github.com/Wei-Shaw/sub2api/internal/pkg/errors"
"github.com/stretchr/testify/require"
)
func TestMergePlatformQuotaDefaults_PatchSemantics(t *testing.T) {
five := 5.0
base := DefaultPlatformQuotaSetting{
DailyLimitUSD: &five,
WeeklyLimitUSD: &five,
}
ten := 10.0
patch := DefaultPlatformQuotaSetting{DailyLimitUSD: &ten}
mergePlatformQuotaDefaults(&base, &patch)
if base.DailyLimitUSD == nil || *base.DailyLimitUSD != 10.0 {
t.Errorf("daily not patched: %+v", base.DailyLimitUSD)
}
if base.WeeklyLimitUSD == nil || *base.WeeklyLimitUSD != 5.0 {
t.Errorf("weekly should remain 5.0: %+v", base.WeeklyLimitUSD)
}
}
func TestMergePlatformQuotaDefaults_ZeroIsExplicitDisable(t *testing.T) {
five := 5.0
base := DefaultPlatformQuotaSetting{DailyLimitUSD: &five}
zero := 0.0
patch := DefaultPlatformQuotaSetting{DailyLimitUSD: &zero}
mergePlatformQuotaDefaults(&base, &patch)
if base.DailyLimitUSD == nil || *base.DailyLimitUSD != 0 {
t.Errorf("explicit 0 should patch base, got %+v", base.DailyLimitUSD)
}
}
func TestMergePlatformQuotaDefaults_NilSrcIsNoop(t *testing.T) {
five := 5.0
base := DefaultPlatformQuotaSetting{DailyLimitUSD: &five}
mergePlatformQuotaDefaults(&base, nil)
if base.DailyLimitUSD == nil || *base.DailyLimitUSD != 5.0 {
t.Errorf("nil src should be no-op: %+v", base.DailyLimitUSD)
}
}
func floatPtrPQ(v float64) *float64 { return &v }
func newSettingServiceForPlatformQuotaTest(seed map[string]string) *SettingService {
repo := newMockSettingRepo()
for k, v := range seed {
repo.data[k] = v
}
return NewSettingService(repo, &config.Config{})
}
func TestGetDefaultPlatformQuotas_ReturnsAllowedPlatforms(t *testing.T) {
zero := 0.0
svc := newSettingServiceForPlatformQuotaTest(map[string]string{
// 新 JSON 格式:anthropic daily=10.5, openai monthly=0, 其他平台无配置
SettingKeyDefaultPlatformQuotas: `{"anthropic":{"daily":10.5},"openai":{"monthly":0}}`,
})
got, err := svc.GetDefaultPlatformQuotas(context.Background())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
// 必须包含全部允许 platform key(补齐契约)
for _, platform := range AllowedQuotaPlatforms {
if _, ok := got[platform]; !ok {
t.Errorf("missing platform key: %q", platform)
}
}
// anthropic daily = 10.5
if v := got["anthropic"].DailyLimitUSD; v == nil || *v != 10.5 {
t.Errorf("anthropic daily want 10.5, got %v", v)
}
// openai monthly = 0(显式禁用)
if v := got["openai"].MonthlyLimitUSD; v == nil || *v != zero {
t.Errorf("openai monthly want 0 (explicit disable), got %v", v)
}
// gemini 无配置 → weekly = nil
if v := got["gemini"].WeeklyLimitUSD; v != nil {
t.Errorf("gemini weekly want nil (not configured), got %v", *v)
}
// antigravity 无配置 → daily = nil
if v := got["antigravity"].DailyLimitUSD; v != nil {
t.Errorf("antigravity daily want nil (not configured), got %v", *v)
}
}
func TestGetAuthSourcePlatformQuotas_OnlyConfiguredReturned(t *testing.T) {
source := "email"
// 新 JSON 格式:anthropic daily=5, monthly=100openai weekly=0gemini/antigravity 无配置
svc := newSettingServiceForPlatformQuotaTest(map[string]string{
SettingKeyAuthSourcePlatformQuotas(source): `{"anthropic":{"daily":5,"monthly":100},"openai":{"weekly":0}}`,
})
got := svc.GetAuthSourcePlatformQuotas(context.Background(), source)
// anthropic 有配置 → 在结果中
anthro, ok := got["anthropic"]
if !ok {
t.Fatal("expected anthropic to be present")
}
if anthro.DailyLimitUSD == nil || *anthro.DailyLimitUSD != 5.0 {
t.Errorf("anthropic daily want 5.0, got %v", anthro.DailyLimitUSD)
}
if anthro.MonthlyLimitUSD == nil || *anthro.MonthlyLimitUSD != 100.0 {
t.Errorf("anthropic monthly want 100.0, got %v", anthro.MonthlyLimitUSD)
}
if anthro.WeeklyLimitUSD != nil {
t.Errorf("anthropic weekly not configured, want nil, got %v", *anthro.WeeklyLimitUSD)
}
// openai weekly=0 → 在结果中
oai, ok := got["openai"]
if !ok {
t.Fatal("expected openai to be present")
}
if oai.WeeklyLimitUSD == nil || *oai.WeeklyLimitUSD != 0 {
t.Errorf("openai weekly want 0, got %v", oai.WeeklyLimitUSD)
}
// gemini / antigravity 无配置 → 不在结果中(override 语义)
if _, ok := got["gemini"]; ok {
t.Error("gemini not configured, should be absent from result")
}
if _, ok := got["antigravity"]; ok {
t.Error("antigravity not configured, should be absent from result")
}
}
func TestGetAuthSourcePlatformQuotas_AllNegativeOrEmpty_NoEntry(t *testing.T) {
source := "linuxdo"
// 新 JSON 格式:未配置任何平台(空 JSON key)→ 返回空 map
svc := newSettingServiceForPlatformQuotaTest(map[string]string{
SettingKeyAuthSourcePlatformQuotas(source): `{}`,
})
got := svc.GetAuthSourcePlatformQuotas(context.Background(), source)
// 空 map → override 语义,无 openai 条目
if _, ok := got["openai"]; ok {
t.Error("empty JSON object should result in no openai entry")
}
if len(got) != 0 {
t.Errorf("expected empty result map, got %v", got)
}
}
// TestSystemPlatformQuotas_WriteReadRoundTrip 验证系统层 platform quota 经 buildSystemSettingsUpdates(写)
// 再由 GetDefaultPlatformQuotas(读)正确往返,覆盖真实 write→read 路径并锁住平台补齐契约。
func TestSystemPlatformQuotas_WriteReadRoundTrip(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(nil)
ctx := context.Background()
ten := 10.0
ss := &SystemSettings{
DefaultPlatformQuotas: map[string]*DefaultPlatformQuotaSetting{
"anthropic": {DailyLimitUSD: &ten, WeeklyLimitUSD: nil, MonthlyLimitUSD: nil},
},
}
if err := svc.UpdateSettings(ctx, ss); err != nil {
t.Fatalf("UpdateSettings: %v", err)
}
got, err := svc.GetDefaultPlatformQuotas(ctx)
if err != nil {
t.Fatal(err)
}
// 平台补齐契约:无论写了几个 platform,读回必须含全部允许平台
for _, p := range AllowedQuotaPlatforms {
if _, ok := got[p]; !ok {
t.Errorf("allowed-platform contract violated: missing platform %q", p)
}
}
// 写入值正确往返
if v := got["anthropic"].DailyLimitUSD; v == nil || *v != ten {
t.Fatalf("anthropic daily round-trip failed: got %v, want 10", v)
}
// 未写入的平台字段为 nil
if got["openai"].DailyLimitUSD != nil {
t.Errorf("openai daily should be nil (not written), got %v", got["openai"].DailyLimitUSD)
}
}
// TestSystemPlatformQuotas_EmptyMapClearsAll 验证空 map 的整体替换语义:
// 写入 DefaultPlatformQuotas={} 后,GetDefaultPlatformQuotas 返回全部允许平台、所有字段均为 nil,
// 明确文档化"空 map = 清空全部配额"是有意为之的 whole-replace 语义。
func TestSystemPlatformQuotas_EmptyMapClearsAll(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(nil)
ctx := context.Background()
// 先写入有值的配置
ten := 10.0
if err := svc.UpdateSettings(ctx, &SystemSettings{
DefaultPlatformQuotas: map[string]*DefaultPlatformQuotaSetting{
"anthropic": {DailyLimitUSD: &ten},
},
}); err != nil {
t.Fatalf("initial write: %v", err)
}
// 再写入空 map(整体替换语义:清空全部)
if err := svc.UpdateSettings(ctx, &SystemSettings{
DefaultPlatformQuotas: map[string]*DefaultPlatformQuotaSetting{},
}); err != nil {
t.Fatalf("empty map write: %v", err)
}
got, err := svc.GetDefaultPlatformQuotas(ctx)
if err != nil {
t.Fatal(err)
}
// 全部允许平台 key 仍然存在(补齐契约)
for _, p := range AllowedQuotaPlatforms {
if _, ok := got[p]; !ok {
t.Errorf("allowed-platform contract violated after empty write: missing %q", p)
}
}
// 所有字段 nil(全部已清空)
for _, p := range AllowedQuotaPlatforms {
pq := got[p]
if pq == nil {
continue
}
if pq.DailyLimitUSD != nil || pq.WeeklyLimitUSD != nil || pq.MonthlyLimitUSD != nil {
t.Errorf("platform %q should have all-nil limits after empty-map write, got %+v", p, pq)
}
}
}
// TestUpdateSettingsWithAuthSourceDefaults_PlatformQuotaRoundTrip 验证 round-4 fix
// PUT /admin/settings 携带的 auth source × platform × window 限额能完整写入并被 GetAuthSourcePlatformQuotas 读回。
// Round-4 之前 writeProviderDefaultGrantUpdates 完全没写 PQ key,前端配置静默丢失。
func TestUpdateSettingsWithAuthSourceDefaults_PlatformQuotaRoundTrip(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(nil)
systemSettings := &SystemSettings{}
authDefaults := &AuthSourceDefaultSettings{
Email: ProviderDefaultGrantSettings{
PlatformQuotas: map[string]*DefaultPlatformQuotaSetting{
"anthropic": {
DailyLimitUSD: floatPtrPQ(5.0),
WeeklyLimitUSD: nil, // 无限额
MonthlyLimitUSD: floatPtrPQ(100.0),
},
"openai": {
DailyLimitUSD: floatPtrPQ(0), // 显式禁用
},
},
},
}
if err := svc.UpdateSettingsWithAuthSourceDefaults(context.Background(), systemSettings, authDefaults); err != nil {
t.Fatalf("UpdateSettingsWithAuthSourceDefaults: %v", err)
}
got := svc.GetAuthSourcePlatformQuotas(context.Background(), "email")
anthro := got["anthropic"]
if anthro == nil || anthro.DailyLimitUSD == nil || *anthro.DailyLimitUSD != 5.0 {
t.Errorf("anthropic daily round-trip failed: %+v", anthro)
}
if anthro != nil && anthro.WeeklyLimitUSD != nil {
t.Errorf("anthropic weekly want nil (无限额), got %v", *anthro.WeeklyLimitUSD)
}
if anthro == nil || anthro.MonthlyLimitUSD == nil || *anthro.MonthlyLimitUSD != 100.0 {
t.Errorf("anthropic monthly round-trip failed: %+v", anthro)
}
oai := got["openai"]
if oai == nil || oai.DailyLimitUSD == nil || *oai.DailyLimitUSD != 0 {
t.Errorf("openai daily=0 (禁用) round-trip failed: %+v", oai)
}
// 其他 source 不应有 quotaauthDefaults 只填了 Email
if linux := svc.GetAuthSourcePlatformQuotas(context.Background(), "linuxdo"); len(linux) != 0 {
t.Errorf("linuxdo should be empty, got %+v", linux)
}
}
// TestUpdateSettingsWithAuthSourceDefaults_NilPlatformQuotaPreservesExisting 验证 #2 防御:
// 请求未携带某 auth source 的 platform quotanil)时跳过写入、保留既有配置,
// 而非整体替换为空 map 清空(与系统层 nil 守卫一致)。
func TestUpdateSettingsWithAuthSourceDefaults_NilPlatformQuotaPreservesExisting(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(map[string]string{
SettingKeyAuthSourcePlatformQuotas("email"): `{"anthropic":{"daily":5,"weekly":null,"monthly":null}}`,
})
// authDefaults 不携带 Email 的 PlatformQuotasnil)——应保留既有配置
authDefaults := &AuthSourceDefaultSettings{
Email: ProviderDefaultGrantSettings{PlatformQuotas: nil},
}
if err := svc.UpdateSettingsWithAuthSourceDefaults(context.Background(), &SystemSettings{}, authDefaults); err != nil {
t.Fatalf("UpdateSettingsWithAuthSourceDefaults: %v", err)
}
anthro := svc.GetAuthSourcePlatformQuotas(context.Background(), "email")["anthropic"]
if anthro == nil || anthro.DailyLimitUSD == nil || *anthro.DailyLimitUSD != 5.0 {
t.Errorf("nil PlatformQuotas 应保留既有 anthropic daily=5got %+v", anthro)
}
}
// TestGetAuthSourcePlatformQuotas_JSON 验证新 JSON key 读写语义:
// 写入 JSON,断言已配置平台在结果中、未配置平台不在结果中(override 语义)。
func TestGetAuthSourcePlatformQuotas_JSON(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(map[string]string{
SettingKeyAuthSourcePlatformQuotas("email"): `{"openai":{"daily":null,"weekly":null,"monthly":20}}`,
})
got := svc.GetAuthSourcePlatformQuotas(context.Background(), "email")
// openai monthly = 20
oai, ok := got["openai"]
if !ok {
t.Fatal("expected openai to be present")
}
if oai.MonthlyLimitUSD == nil || *oai.MonthlyLimitUSD != 20 {
t.Errorf("openai monthly want 20, got %v", oai.MonthlyLimitUSD)
}
if oai.DailyLimitUSD != nil {
t.Errorf("openai daily want nil, got %v", *oai.DailyLimitUSD)
}
if oai.WeeklyLimitUSD != nil {
t.Errorf("openai weekly want nil, got %v", *oai.WeeklyLimitUSD)
}
// anthropic 未配置 → 不在结果中(override 语义)
if _, ok := got["anthropic"]; ok {
t.Error("anthropic not configured, should be absent from result")
}
}
// TestUpdateSettingsWithAuthSourceDefaults_NegativeQuotaRejected 验证改动 C
// auth-source platform quota 含负数时,UpdateSettingsWithAuthSourceDefaults 返回 BadRequest 错误。
func TestUpdateSettingsWithAuthSourceDefaults_NegativeQuotaRejected(t *testing.T) {
svc := newSettingServiceForPlatformQuotaTest(nil)
neg := -1.0
authDefaults := &AuthSourceDefaultSettings{
Email: ProviderDefaultGrantSettings{
PlatformQuotas: map[string]*DefaultPlatformQuotaSetting{
"anthropic": {DailyLimitUSD: &neg},
},
},
}
err := svc.UpdateSettingsWithAuthSourceDefaults(context.Background(), &SystemSettings{}, authDefaults)
require.Error(t, err, "expected error for negative quota")
require.Equal(t, "INVALID_DEFAULT_PLATFORM_QUOTA", infraerrors.Reason(err))
}